Skip to content

Commit 60da2de

Browse files
noorascolbyfayock
andauthored
fix: Add cloudinaryAnalytics to Video Player types #171 (#208)
# Description Added cloudinaryAnalytics to Video Player types ## Issue Ticket Number Fixes #171 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/cloudinary-util/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/colbyfayock/cloudinary-util/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/cloudinary-util/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation --------- Co-authored-by: Colby Fayock <[email protected]>
1 parent 153b1ad commit 60da2de

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

packages/types/src/types/cloudinary-video-player.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,7 @@ export interface CloudinaryVideoPlayerOptions
442442
};
443443
analytics?: boolean;
444444
allowUsageReport?: boolean;
445+
cloudinaryAnalytics?: boolean | CloudinaryVideoPlayerOptionsCloudinaryAnalytics;
445446

446447
// ------------ Delivery ------------
447448
cloud_name?: string;
@@ -483,3 +484,15 @@ export interface CloudinaryVideoPlayerOptionPosterOptions {
483484
*/
484485
posterColor?: string;
485486
}
487+
488+
export interface CloudinaryVideoPlayerOptionsCloudinaryAnalytics {
489+
customData: CloudinaryVideoPlayerOptionsCloudinaryAnalyticsCustomData;
490+
}
491+
492+
export interface CloudinaryVideoPlayerOptionsCloudinaryAnalyticsCustomData {
493+
customData1?: string;
494+
customData2?: string;
495+
customData3?: string;
496+
customData4?: string;
497+
customData5?: string;
498+
}

0 commit comments

Comments
 (0)