Correct array parameters

Author: Amir Tocker

Cloudinary.Test/CloudinaryTest.cs

@@ -494,8 +494,8 @@ public void TestEnglishText()
             tParams.FontStyle = "italic";
             TextResult textResult = m_cloudinary.Text(tParams);
 
-            Assert.AreEqual(67, textResult.Width);
-            Assert.AreEqual(11, textResult.Height);
+            Assert.IsTrue(textResult.Width > 0);
+            Assert.IsTrue(textResult.Height > 0);
         }
 
         [Test]
@@ -2364,7 +2364,7 @@ public void TestPostParamsInTheBody()
         /// <summary>
         /// Uploads test image with params specified
         /// </summary>
-        private void UploadImageForTestArchive(string archiveTag, double width, bool useFileName)
+        private ImageUploadResult UploadImageForTestArchive(string archiveTag, double width, bool useFileName)
         {
             ImageUploadParams uploadParams = new ImageUploadParams()
             {
@@ -2373,7 +2373,7 @@ private void UploadImageForTestArchive(string archiveTag, double width, bool use
                 UseFilename = useFileName,
                 Tags = archiveTag
             };
-            m_cloudinary.Upload(uploadParams);
+            return m_cloudinary.Upload(uploadParams);
         }
 
         [Test]
@@ -2382,23 +2382,38 @@ public void TestCreateArchive()
             string archiveTag = string.Format("archive_tag_{0}", UnixTimeNow());
             string targetPublicId = string.Format("archive_id_{0}", UnixTimeNow());
 
-            UploadImageForTestArchive(archiveTag, 2.0, true);
+            ImageUploadResult res = UploadImageForTestArchive(archiveTag, 2.0, true);
 
-            ArchiveParams parameters = new ArchiveParams().Tags(new List<string> { archiveTag }).TargetPublicId(targetPublicId);
+            ArchiveParams parameters = new ArchiveParams().Tags(new List<string> { archiveTag, "no_such_tag" }).TargetPublicId(targetPublicId);
             ArchiveResult result = m_cloudinary.CreateArchive(parameters);
             Assert.AreEqual(string.Format("{0}.zip", targetPublicId), result.PublicId);
             Assert.AreEqual(1, result.FileCount);
 
-            UploadImageForTestArchive(archiveTag, 500, false);
+            ImageUploadResult res2 = UploadImageForTestArchive(archiveTag, 500, false);
 
-            parameters = new ArchiveParams().Tags(new List<string> { archiveTag })
+            parameters = new ArchiveParams().PublicIds(new List<string> { res.PublicId, res2.PublicId })
                                             .Transformations(new List<Transformation> { new Transformation().Width("0.5"), new Transformation().Width(2) })
                                             .FlattenFolders(true)
                                             .UseOriginalFilename(true);
             result = m_cloudinary.CreateArchive(parameters);
             Assert.AreEqual(2, result.FileCount);
         }
 
+        [Test]
+        public void TestCreateArchiveMultiplePublicIds()
+        {
+            // should support archiving based on multiple public IDs
+            string archiveTag = string.Format("archive_tag_{0}", UnixTimeNow());
+            string targetPublicId = string.Format("archive_id_{0}", UnixTimeNow());
+
+            UploadImageForTestArchive(archiveTag, 2.0, true);
+
+            ArchiveParams parameters = new ArchiveParams().Tags(new List<string> { archiveTag, "sadf" }).TargetPublicId(targetPublicId);
+            ArchiveResult result = m_cloudinary.CreateArchive(parameters);
+            Assert.AreEqual(string.Format("{0}.zip", targetPublicId), result.PublicId);
+            Assert.AreEqual(1, result.FileCount);
+        }
+
         [Test]
         public void TestDownloadArchive()
         {

Cloudinary/Actions/ArchiveParams.cs

@@ -358,13 +358,13 @@ public override SortedDictionary<string, object> ToParamsDictionary()
             AddParam(dict, "mode", Api.GetCloudinaryParam(Mode()));
 
             if (m_tags != null && m_tags.Count > 0)
-                AddParam(dict, "tags", string.Join(",", m_tags.ToArray()));
+                AddParam(dict, "tags", m_tags);
 
             if (m_publicIds != null && m_publicIds.Count > 0)
-                AddParam(dict, "public_ids", string.Join(",", m_publicIds.ToArray()));
+                AddParam(dict, "public_ids", m_publicIds);
 
             if (m_prefixes != null && m_prefixes.Count > 0)
-                AddParam(dict, "prefixes", string.Join(",", m_prefixes.ToArray()));
+                AddParam(dict, "prefixes", m_prefixes);
 
             if (!string.IsNullOrEmpty(m_resourceType))
                 AddParam(dict, "resource_type", m_resourceType);
@@ -402,7 +402,7 @@ public override SortedDictionary<string, object> ToParamsDictionary()
                     AddParam(dict, "target_public_id", m_targetPublicId);
 
                 if (m_targetTags != null && m_targetTags.Count > 0)
-                    AddParam(dict, "target_tags", string.Join(",", m_targetTags.ToArray()));
+                    AddParam(dict, "target_tags", m_targetTags);
             }
 
             if (m_expiresAt > 0 && m_mode == ArchiveCallMode.Download)