Fix no configuration error message

Author: const-cloudinary

cloudinary_cli/core/config.py

@@ -21,7 +21,7 @@ def config(new, ls, show, rm, from_url):
         config_name, cloudinary_url = new or [None, from_url]
 
         if not verify_cloudinary_url(cloudinary_url):
-            return 1
+            return False
 
         config_name = config_name or cloudinary.config().cloud_name
 
@@ -44,6 +44,7 @@ def config(new, ls, show, rm, from_url):
         config_obj = cloudinary.Config()
         # noinspection PyProtectedMember
         config_obj._setup_from_parsed_url(config_obj._parse_cloudinary_url(load_config()[show]))
-        show_cloudinary_config(config_obj)
+
+        return show_cloudinary_config(config_obj)
     else:
-        show_cloudinary_config(cloudinary.config())
+        return show_cloudinary_config(cloudinary.config())

cloudinary_cli/utils/config_utils.py

@@ -54,6 +54,7 @@ def verify_cloudinary_url(cloudinary_url):
 
 def show_cloudinary_config(cloudinary_config):
     obfuscated_config = {k: v for k, v in cloudinary_config.__dict__.items() if not k.startswith("_")}
+
     if "api_secret" in obfuscated_config:
         api_secret = obfuscated_config["api_secret"]
         obfuscated_config["api_secret"] = "*" * (len(api_secret) - 4) + f"{api_secret[-4:]}"
@@ -62,6 +63,9 @@ def show_cloudinary_config(cloudinary_config):
     if obfuscated_config.get("signature_algorithm", None) == cloudinary.utils.SIGNATURE_SHA1:
         obfuscated_config.pop("signature_algorithm")
 
+    if not obfuscated_config:
+        return False
+
     template = "{0:" + str(len(max(obfuscated_config, key=len)) + 1) + "} {1}"  # Gets the maximal length of the keys.
     echo('\n'.join([template.format(f"{k}:", v) for k, v in obfuscated_config.items()]))
 

test/test_cli_config.py

@@ -23,6 +23,7 @@ class TestCLIConfig(unittest.TestCase):
     TEST_CLOUD_NAME = 'test_cloud'
     TEST_CLOUDINARY_URL = 'cloudinary://key:secret@' + TEST_CLOUD_NAME
     INVALID_CLOUDINARY_URL = 'cloudinary://key:secret@'
+    EMPTY_CLOUDINARY_URL = 'cloudinary://'
 
     @classmethod
     def tearDownClass(cls) -> None:
@@ -85,6 +86,16 @@ def test_cli_config_show(self):
         for value in ['cloud_name', 'api_key', 'api_secret', self.REAL_CLOUD_NAME]:
             self.assertIn(value, result.output)
 
+    @unittest.skipUnless(cloudinary.config().api_secret, "Requires api_key/api_secret")
+    def test_cli_config_show_default_no_config(self):
+        self.runner.invoke(cli, ['config', '--from_url', self.EMPTY_CLOUDINARY_URL])
+
+        result = self.runner.invoke(cli, ['config'])
+
+        self.assertEqual(1, result.exit_code)
+
+        self.assertIn("No Cloudinary configuration found", result.output)
+
     def test_cli_config_show_non_existent(self):
         result = self.runner.invoke(cli, ['config', '--show', self.TEST_CLOUD_NAME])