Skip to content

Commit 620b4a0

Browse files
committed
fix: improved analytics
1 parent e20c01e commit 620b4a0

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/utils/get-analytics-player-options.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import defaults from 'config/defaults';
22
import isEmpty from 'lodash/isEmpty';
3-
import isObject from 'lodash/isObject';
43

54
const hasConfig = (obj) => isEmpty(obj) ? null : true;
65

@@ -44,7 +43,7 @@ const getSourceOptions = (sourceOptions = {}) => ({
4443
} : {}),
4544
...(hasConfig(sourceOptions.textTracks) ? getTextTracksOptions(sourceOptions.textTracks) : {}),
4645
interactionAreas: hasConfig(sourceOptions.interactionAreas),
47-
videoSources: !!sourceOptions.videoSources || null,
46+
videoSources: hasConfig(sourceOptions.videoSources),
4847
});
4948

5049
const getTextTracksOptions = (textTracks = {}) => {
@@ -96,8 +95,7 @@ export const getAnalyticsFromPlayerOptions = (playerOptions) => filterDefaultsAn
9695
autoplayMode: playerOptions.autoplayMode,
9796
bigPlayButton: playerOptions.bigPlayButton,
9897
className: playerOptions.class,
99-
cloudinaryAnalytics: !!playerOptions.cloudinaryAnalytics,
100-
cloudinaryAnalyticsOptions: isObject(playerOptions.cloudinaryAnalytics) || null,
98+
cloudinaryAnalytics: hasConfig(playerOptions.cloudinaryAnalytics),
10199
controls: playerOptions.controls,
102100
floatingWhenNotVisible: playerOptions.floatingWhenNotVisible,
103101
fluid: playerOptions.fluid,
@@ -126,8 +124,8 @@ export const getAnalyticsFromPlayerOptions = (playerOptions) => filterDefaultsAn
126124
debug: playerOptions.debug,
127125
type: playerOptions.type,
128126

129-
colors: playerOptions.colors && JSON.stringify(playerOptions.colors),
130-
controlBar: (JSON.stringify(playerOptions.controlBar) !== JSON.stringify(defaults.controlBar)) && JSON.stringify(playerOptions.controlBar),
127+
colors: hasConfig(playerOptions.colors),
128+
controlBar: hasConfig(playerOptions.controlBar),
131129

132130
...getSourceOptions(playerOptions.sourceOptions || {}),
133131
...getAdsOptions(playerOptions.ads),

0 commit comments

Comments
 (0)