Skip to content

Commit 9078809

Browse files
authored
Merge pull request #113 from cloudinary/APPS-363-floating-player-ui
APPS-363 Floating player UI tweaks
2 parents db29ee8 + cd7ec86 commit 9078809

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

src/assets/styles/main.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@ $icon-font-path: '../fonts' !default;
131131

132132
left: 50%;
133133
top: 50%;
134-
margin-left: -($big-play-width / 2);
135-
margin-top: -($big-play-height / 2);
134+
transform: translateX(-50%) translateY(-50%);
136135
}
137136

138137
&.vjs-paused .vjs-big-play-button,

src/plugins/colors/index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ const playerColors = `
8181
.PLAYER-CLASS-PREFIX .cld-plw-panel-item {
8282
border-color: --text-color;
8383
}
84+
85+
.PLAYER-CLASS-PREFIX .cld-video-player-floater-close polygon {
86+
fill: --base-color;
87+
}
8488
`;
8589

8690
const darkOnlyColors = `

src/plugins/floating-player/floating-player.scss

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
position: fixed;
1313
z-index: 9;
1414
border: 4px solid #fff;
15-
box-shadow: 0 0 10px rgba(#000, .3);
15+
box-shadow: 0 3px 10px rgba(#000, .2);
1616

1717
.cld-video-player-floater-inner {
1818
height: 0;
@@ -22,14 +22,24 @@
2222
.cld-video-player-floater-close {
2323
position: absolute;
2424
bottom: 100%;
25-
color: #999;
2625
background: #fff;
27-
border: 1px solid #e6e6e6;
2826
border-bottom: none;
2927
margin-bottom: 4px;
28+
right: -4px;
3029
padding: 4px 6px 2px;
3130
display: block;
31+
box-shadow: 0 0 4px rgba(#000, .05);
3232
cursor: pointer;
33+
// Hide bottom shadow
34+
&::after {
35+
content: '';
36+
position: absolute;
37+
top: 100%;
38+
right: 0;
39+
width: 120%;
40+
height: 4px;
41+
background: #fff;
42+
}
3343
}
3444

3545
.vjs-time-control,
@@ -41,24 +51,23 @@
4151
background-color: transparent;
4252
}
4353

54+
.vjs-big-play-button {
55+
font-size: 4em;
56+
top: 40%;
57+
}
58+
4459
&.cld-video-player-floater-bottom-right {
4560
bottom: 20px !important;
4661
right: 20px !important;
4762
top: auto !important;
4863
left: auto !important;
49-
.cld-video-player-floater-close {
50-
right: 0;
51-
}
5264
}
5365

5466
&.cld-video-player-floater-bottom-left {
5567
bottom: 20px !important;
5668
left: 20px !important;
5769
top: auto !important;
5870
right: auto !important;
59-
.cld-video-player-floater-close {
60-
left: 0;
61-
}
6271
}
6372

6473
}

src/plugins/floating-player/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class FloatingPlayer {
8181

8282
const close = document.createElement('button');
8383
close.setAttribute('class', 'cld-video-player-floater-close');
84-
close.innerHTML = 'X';
84+
close.innerHTML = '<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 12 12"><polygon fill-rule="evenodd" points="370 7.41 368.59 6 364 10.59 359.41 6 358 7.41 362.59 12 358 16.59 359.41 18 364 13.41 368.59 18 370 16.59 365.41 12" transform="translate(-358 -6)"/></svg>';
8585
close.onclick = () => {
8686
unfloat();
8787
disable();

0 commit comments

Comments
 (0)