From 57ae8fc62d0042f9822dc834fac6e394da4a9c9a Mon Sep 17 00:00:00 2001 From: Tsachi Shlidor Date: Tue, 26 Nov 2024 13:07:35 +0200 Subject: [PATCH 1/2] fix: source analytics --- src/video-player.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video-player.js b/src/video-player.js index 61f1b180..118afca3 100644 --- a/src/video-player.js +++ b/src/video-player.js @@ -476,7 +476,7 @@ class VideoPlayer extends Utils.mixin(Eventable) { } _onSourceChange(e, { sourceOptions }) { - this._sendInternalAnalytics({ ...(sourceOptions ?? { source: sourceOptions }) }); + this._sendInternalAnalytics({ ...(sourceOptions && { source: sourceOptions }) }); // #if (!process.env.WEBPACK_BUILD_LIGHT) this._initQualitySelector(); // #endif From 047fddaf4430a34a19fa1739a4eac0114bbebd4c Mon Sep 17 00:00:00 2001 From: Tsachi Shlidor Date: Tue, 26 Nov 2024 16:45:09 +0200 Subject: [PATCH 2/2] chore: cleanup --- src/utils/get-analytics-player-options.js | 2 +- src/video-player.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils/get-analytics-player-options.js b/src/utils/get-analytics-player-options.js index fd3065fa..28209f73 100644 --- a/src/utils/get-analytics-player-options.js +++ b/src/utils/get-analytics-player-options.js @@ -100,7 +100,7 @@ export const getAnalyticsFromPlayerOptions = (playerOptions) => filterDefaultsAn controlBar: (JSON.stringify(playerOptions.controlBar) !== JSON.stringify(defaults.controlBar)) && JSON.stringify(playerOptions.controlBar), ...getCloudinaryOptions(playerOptions.cloudinary), - ...getSourceOptions(playerOptions.source), + ...getSourceOptions(playerOptions.sourceOptions), ...getAdsOptions(playerOptions.ads), ...getPlaylistWidgetOptions(playerOptions.playlistWidget) }); diff --git a/src/video-player.js b/src/video-player.js index 118afca3..f219b524 100644 --- a/src/video-player.js +++ b/src/video-player.js @@ -476,7 +476,7 @@ class VideoPlayer extends Utils.mixin(Eventable) { } _onSourceChange(e, { sourceOptions }) { - this._sendInternalAnalytics({ ...(sourceOptions && { source: sourceOptions }) }); + this._sendInternalAnalytics({ ...(sourceOptions && { sourceOptions }) }); // #if (!process.env.WEBPACK_BUILD_LIGHT) this._initQualitySelector(); // #endif