Optimize synchronization

Amir Tocker · Amir Tocker · commit 33f3e27d2415 · 2017-08-07T15:21:09.000+03:00
diff --git a/lib/src/main/java/com/cloudinary/android/UploadRequest.java b/lib/src/main/java/com/cloudinary/android/UploadRequest.java
@@ -133,9 +133,11 @@ public synchronized String dispatch() {
     }
 
     private void verifyOptionsExist() {
-        synchronized (optionsLockObject) {
-            if (options == null) {
-                options = new HashMap<>();
+        if (options == null) {
+            synchronized (optionsLockObject) {
+                if (options == null) {
+                    options = new HashMap<>();
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,11 @@ public synchronized String dispatch() {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`private void verifyOptionsExist() {`
`136`		`- synchronized (optionsLockObject) {`
`137`		`- if (options == null) {`
`138`		`- options = new HashMap<>();`
	`136`	`+ if (options == null) {`
	`137`	`+ synchronized (optionsLockObject) {`
	`138`	`+ if (options == null) {`
	`139`	`+ options = new HashMap<>();`
	`140`	`+ }`
`139`	`141`	`}`
`140`	`142`	`}`
`141`	`143`	`}`