Skip to content

Commit 78990df

Browse files
committed
Fix sample app video thumbnails generation
1 parent 4e8be2e commit 78990df

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

sample/src/main/java/com/cloudinary/android/sample/app/EffectsGalleryAdapter.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ class EffectsGalleryAdapter extends RecyclerView.Adapter<EffectsGalleryAdapter.I
2525
private List<EffectData> images;
2626
private Context context;
2727
private EffectData selected = null;
28+
private String resourceType;
2829

29-
EffectsGalleryAdapter(Context context, List<EffectData> images, int requiredSize, ItemClickListener listener) {
30+
EffectsGalleryAdapter(Context context, List<EffectData> images, String resourceType, int requiredSize, ItemClickListener listener) {
3031
this.context = context;
32+
this.resourceType = resourceType;
3133
this.images = images;
3234
this.requiredSize = requiredSize;
3335
this.listener = listener;
@@ -63,7 +65,8 @@ public void onBindViewHolder(final EffectsGalleryAdapter.ImageViewHolder holder,
6365
holder.itemView.setTag(images.get(position));
6466
holder.nameTextView.setText(data.getName());
6567

66-
Url baseUrl = MediaManager.get().url().publicId(data.getPublicId()).transformation(data.getTransformation());
68+
// force image format (webp in this case) so that both video and images are downloaded as images.
69+
Url baseUrl = MediaManager.get().url().format("webp").resourceType(resourceType).publicId(data.getPublicId()).transformation(data.getTransformation());
6770
MediaManager.get().responsiveUrl(AUTO_FILL)
6871
.stepSize(50)
6972
.generate(baseUrl, holder.imageView, new ResponsiveUrl.Callback() {

sample/src/main/java/com/cloudinary/android/sample/app/ImageActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public boolean onPreDraw() {
161161
recyclerView.getViewTreeObserver().removeOnPreDrawListener(this);
162162
thumbHeight = Math.round((float) (recyclerView.getWidth() / 4));
163163
List<EffectData> data = CloudinaryHelper.generateEffectsList(ImageActivity.this, resource);
164-
recyclerView.setAdapter(new EffectsGalleryAdapter(ImageActivity.this, data, thumbHeight, new EffectsGalleryAdapter.ItemClickListener() {
164+
recyclerView.setAdapter(new EffectsGalleryAdapter(ImageActivity.this, data, resource.getResourceType(), thumbHeight, new EffectsGalleryAdapter.ItemClickListener() {
165165
@Override
166166
public void onClick(EffectData data) {
167167
updateMainImage(data);
@@ -197,7 +197,7 @@ private void loadVideo(final EffectData data) {
197197
imageView.setVisibility(View.GONE);
198198
final DataSource.Factory dataSourceFactory = new DefaultDataSourceFactory(this, Util.getUserAgent(this, "Cloudinary Sample App"), null);
199199
final ExtractorsFactory extractorsFactory = new DefaultExtractorsFactory();
200-
Url baseUrl = MediaManager.get().url().publicId(data.getPublicId()).transformation(data.getTransformation());
200+
Url baseUrl = MediaManager.get().url().resourceType("video").publicId(data.getPublicId()).transformation(data.getTransformation());
201201
MediaManager.get().responsiveUrl(exoPlayerView, baseUrl, FIT, new ResponsiveUrl.Callback() {
202202
@Override
203203
public void onUrlReady(Url url) {

0 commit comments

Comments
 (0)