Add validation for CLOUDINARY_URL scheme (#185)

Author: michalkcloudinay

cloudinary-core/src/main/java/com/cloudinary/Configuration.java

@@ -186,6 +186,9 @@ public static Configuration from(String cloudinaryUrl) {
     static protected Map parseConfigUrl(String cloudinaryUrl) {
         Map params = new HashMap();
         URI cloudinaryUri = URI.create(cloudinaryUrl);
+        if (cloudinaryUri.getScheme() == null || !cloudinaryUri.getScheme().equalsIgnoreCase("cloudinary")){
+            throw new IllegalArgumentException("Invalid CLOUDINARY_URL scheme. Expecting to start with 'cloudinary://'");
+        }
         params.put("cloud_name", cloudinaryUri.getHost());
         if (cloudinaryUri.getUserInfo() != null) {
             String[] creds = cloudinaryUri.getUserInfo().split(":");
@@ -427,4 +430,4 @@ public Builder from(Configuration other) {
             return this;
         }
     }
-}
+}

cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java

@@ -1230,6 +1230,24 @@ public void testConfiguration() throws IllegalAccessException {
         assertFieldsEqual(config, copy);
     }
 
+    @Test
+    public void testCloudinaryUrlValidScheme() {
+        String cloudinaryUrl = "cloudinary://123456789012345:ALKJdjklLJAjhkKJ45hBK92baj3@test";
+        Configuration.from(cloudinaryUrl);
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testCloudinaryUrlInvalidScheme() {
+        String cloudinaryUrl = "https://123456789012345:ALKJdjklLJAjhkKJ45hBK92baj3@test";
+        Configuration.from(cloudinaryUrl);
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testCloudinaryUrlEmptyScheme() {
+        String cloudinaryUrl = " ";
+        Configuration.from(cloudinaryUrl);
+    }
+
     private void assertFieldsEqual(Object a, Object b) throws IllegalAccessException {
         assertEquals("Two objects must be the same class", a.getClass(), b.getClass());
         Field[] fields = a.getClass().getFields();