Fix ParseException when accessing Response.rateLimits with default locale set to non-english.

Author: nitzanj

cloudinary-http42/src/main/java/com/cloudinary/http42/api/Response.java

@@ -4,6 +4,7 @@
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.HashMap;
+import java.util.Locale;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -33,8 +34,7 @@ public HttpResponse getRawHttpResponse() {
     private static final Pattern RATE_LIMIT_REGEX = Pattern
             .compile("X-Feature(\\w*)RateLimit(-Limit|-Reset|-Remaining)");
     private static final String RFC1123_PATTERN = "EEE, dd MMM yyyyy HH:mm:ss z";
-    private static final DateFormat RFC1123 = new SimpleDateFormat(
-            RFC1123_PATTERN);
+    private static final DateFormat RFC1123 = new SimpleDateFormat(RFC1123_PATTERN, Locale.ENGLISH);
 
     public Map<String, RateLimit> rateLimits() throws ParseException {
         Header[] headers = this.response.getAllHeaders();

cloudinary-http43/src/main/java/com/cloudinary/http43/api/Response.java

@@ -3,6 +3,7 @@
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.HashMap;
+import java.util.Locale;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -32,8 +33,7 @@ public HttpResponse getRawHttpResponse() {
     private static final Pattern RATE_LIMIT_REGEX = Pattern
             .compile("X-Feature(\\w*)RateLimit(-Limit|-Reset|-Remaining)");
     private static final String RFC1123_PATTERN = "EEE, dd MMM yyyyy HH:mm:ss z";
-    private static final DateFormat RFC1123 = new SimpleDateFormat(
-            RFC1123_PATTERN);
+    private static final DateFormat RFC1123 = new SimpleDateFormat(RFC1123_PATTERN, Locale.ENGLISH);
 
     public Map<String, RateLimit> rateLimits() throws java.text.ParseException {
         Header[] headers = this.response.getAllHeaders();

cloudinary-http44/src/main/java/com/cloudinary/http44/api/Response.java

@@ -3,6 +3,7 @@
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.HashMap;
+import java.util.Locale;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -32,8 +33,7 @@ public HttpResponse getRawHttpResponse() {
     private static final Pattern RATE_LIMIT_REGEX = Pattern
             .compile("X-Feature(\\w*)RateLimit(-Limit|-Reset|-Remaining)");
     private static final String RFC1123_PATTERN = "EEE, dd MMM yyyyy HH:mm:ss z";
-    private static final DateFormat RFC1123 = new SimpleDateFormat(
-            RFC1123_PATTERN);
+    private static final DateFormat RFC1123 = new SimpleDateFormat(RFC1123_PATTERN, Locale.ENGLISH);
 
     public Map<String, RateLimit> rateLimits() throws java.text.ParseException {
         Header[] headers = this.response.getAllHeaders();

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractApiTest.java

@@ -5,6 +5,7 @@
 import com.cloudinary.Coordinates;
 import com.cloudinary.Transformation;
 import com.cloudinary.api.ApiResponse;
+import com.cloudinary.api.RateLimit;
 import com.cloudinary.api.exceptions.BadRequest;
 import com.cloudinary.api.exceptions.NotFound;
 import com.cloudinary.transformation.TextLayer;
@@ -13,6 +14,7 @@
 import static org.hamcrest.Matchers.hasItem;
 import static org.hamcrest.Matchers.equalTo;
 import org.junit.*;
+import org.junit.rules.ExpectedException;
 import org.junit.rules.TestName;
 
 import java.io.IOException;
@@ -433,6 +435,13 @@ public void test18Usage() throws Exception {
         assertNotNull(result.get("last_updated"));
     }
 
+    @Test
+    public void testRateLimitWithNonEnglishLocale() throws Exception {
+        Locale.setDefault(new Locale("de", "DE"));
+        ApiResponse result = cloudinary.api().usage(new HashMap());
+        Assert.assertNotNull(result.apiRateLimit().getReset());
+    }
+
     @Test
     public void test19Ping() throws Exception {
         // should support ping API call