Support Client Hints.

Author: Amir Tocker

cloudinary-core/src/main/java/com/cloudinary/Configuration.java

@@ -38,6 +38,7 @@ public class Configuration {
     public boolean useRootPath;
     public int timeout;
     public boolean loadStrategies = true;
+    public boolean clientHints = false;
 
     public Configuration() {
     }
@@ -90,8 +91,34 @@ public void update(Map config) {
         this.useRootPath = ObjectUtils.asBoolean(config.get("use_root_path"), false);
         this.loadStrategies = ObjectUtils.asBoolean(config.get("load_strategies"), true);
         this.timeout = ObjectUtils.asInteger(config.get("timeout"), 0);
+        this.clientHints = ObjectUtils.asBoolean(config.get("client_hints"), false);
     }
 
+    @SuppressWarnings("rawtypes")
+    public Map<String, Object> asMap() {
+        Map<String, Object> map = new HashMap<String, Object>();
+        map.put("cloud_name", cloudName);
+        map.put("api_key", apiKey);
+        map.put("api_secret", apiSecret);
+        map.put("secure_distribution", secureDistribution);
+        map.put("cname", cname);
+        map.put("secure", secure);
+        map.put("private_cdn", privateCdn);
+        map.put("cdn_subdomain", cdnSubdomain);
+        map.put("shorten", shorten);
+        map.put("upload_prefix", uploadPrefix);
+        map.put("callback", callback);
+        map.put("proxy_host", proxyHost);
+        map.put("proxy_port", proxyPort);
+        map.put("secure_cdn_subdomain", secureCdnSubdomain);
+        map.put("use_root_path", useRootPath);
+        map.put("load_strategies", loadStrategies);
+        map.put("timeout", timeout);
+        map.put("client_hints", clientHints);
+        return map;
+    }
+
+
     public Configuration(Configuration other) {
         this.cloudName = other.cloudName;
         this.apiKey = other.apiKey;
@@ -109,6 +136,7 @@ public Configuration(Configuration other) {
         this.secureCdnSubdomain = other.secureCdnSubdomain;
         this.useRootPath = other.useRootPath;
         this.timeout = other.timeout;
+        this.clientHints = other.clientHints;
     }
 
     /**
@@ -198,6 +226,7 @@ public static class Builder {
         private boolean useRootPath;
         private boolean loadStrategies = true;
         private int timeout;
+        private boolean clientHints = false;
 
         /**
          * Set the HTTP connection timeout.
@@ -214,7 +243,9 @@ public Builder setTimeout(int timeout) {
          * Creates a {@link Configuration} with the arguments supplied to this builder
          */
         public Configuration build() {
-            return new Configuration(cloudName, apiKey, apiSecret, secureDistribution, cname, uploadPrefix, secure, privateCdn, cdnSubdomain, shorten, callback, proxyHost, proxyPort, secureCdnSubdomain, useRootPath, timeout, loadStrategies);
+            final Configuration configuration = new Configuration(cloudName, apiKey, apiSecret, secureDistribution, cname, uploadPrefix, secure, privateCdn, cdnSubdomain, shorten, callback, proxyHost, proxyPort, secureCdnSubdomain, useRootPath, timeout, loadStrategies);
+            configuration.clientHints = clientHints;
+            return configuration;
         }
 
         /**
@@ -317,6 +348,11 @@ public Builder setLoadStrategies(boolean loadStrategies) {
             return this;
         }
 
+        public Builder setClientHints(boolean clientHints) {
+            this.clientHints = clientHints;
+            return this;
+        }
+
         /**
          * Initialize builder from existing {@link Configuration}
          *
@@ -341,6 +377,7 @@ public Builder from(Configuration other) {
             this.useRootPath = other.useRootPath;
             this.loadStrategies = other.loadStrategies;
             this.timeout = other.timeout;
+            this.clientHints = other.clientHints;
             return this;
         }
     }

cloudinary-core/src/main/java/com/cloudinary/Url.java

@@ -506,7 +506,7 @@ public String imageTag(String source, Map<String, String> attributes) {
         boolean hiDPI = transformation().isHiDPI();
         boolean responsive = transformation().isResponsive();
 
-        if (hiDPI || responsive) {
+        if (!config.clientHints && (hiDPI || responsive)) {
             attributes.put("data-src", url);
             String extraClass = responsive ? "cld-responsive" : "cld-hidpi";
             attributes.put("class", (StringUtils.isBlank(attributes.get("class")) ? "" : attributes.get("class") + " ") + extraClass);

cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java

@@ -494,6 +494,26 @@ public void testImageTag() {
                 result);
     }
 
+    @Test
+    public void testClientHints() {
+        String testTag;
+        String message = "should not implement responsive behaviour if client hints is true";
+        cloudinary.config.clientHints = true;
+        Transformation trans = new Transformation()
+                .crop("scale")
+                .width("auto")
+                .dpr("auto");
+        testTag = cloudinary.url().transformation(trans).imageTag("sample.jpg");
+        assertTrue(testTag.startsWith("<img") );
+        assertFalse(testTag.contains("class="));
+        assertFalse(testTag.contains("data-src"));
+        assertTrue(testTag.contains("src='http://res.cloudinary.com/test123/image/upload/c_scale,dpr_auto,w_auto/sample.jpg'"));
+        testTag = cloudinary.url().transformation(trans).imageTag("sample.jpg");
+        assertTrue(testTag.startsWith("<img") );
+        assertFalse(testTag.contains("class="));
+        assertFalse(testTag.contains("data-src"));
+        assertTrue(testTag.contains("src='http://res.cloudinary.com/test123/image/upload/c_scale,dpr_auto,w_auto/sample.jpg'"));
+}
     @Test
     public void testFolders() {
         // should add version if public_id contains /