Fix double encoding for commas and slashes in text layers (#66)

Encode comma to %252C and slash to %252F

Author: nitzanj

cloudinary-core/src/main/java/com/cloudinary/transformation/TextLayer.java

@@ -96,7 +96,7 @@ public TextLayer text(String text) {
             start = m.end();
         }
         result.append(SmartUrlEncoder.encode(text.substring(start)));
-        this.text = result.toString().replace("%2C", "%E2%80%9A").replace("/", "%E2%81%84");
+        this.text = result.toString().replace("%2C", "%252C").replace("/", "%252F");
         return getThis();
     }
 

cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java

@@ -964,11 +964,13 @@ public void testOverlayOptions() {
                 "logo.png",
                 new Layer().resourceType("video").publicId("cat"),
                 "video:cat",
+                new TextLayer().text("Hello/World").fontFamily("Arial").fontSize(18),
+                "text:Arial_18:Hello%252FWorld",
                 new TextLayer().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18),
-                "text:Arial_18:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new TextLayer().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18)
                         .fontWeight("bold").fontStyle("italic").letterSpacing("4").lineSpacing(3),
-                "text:Arial_18_bold_italic_letter_spacing_4_line_spacing_3:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18_bold_italic_letter_spacing_4_line_spacing_3:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new SubtitlesLayer().publicId("sample_sub_en.srt"), "subtitles:sample_sub_en.srt",
                 new SubtitlesLayer().publicId("sample_sub_he.srt").fontFamily("Arial").fontSize(40),
                 "subtitles:Arial_40:sample_sub_he.srt"};
@@ -995,11 +997,13 @@ public void testBackwardCampatibleOverlayOptions() {
                 "logo.png",
                 new LayerBuilder().resourceType("video").publicId("cat"),
                 "video:cat",
+                new TextLayerBuilder().text("Hello/World").fontFamily("Arial").fontSize(18),
+                "text:Arial_18:Hello%252FWorld",
                 new TextLayerBuilder().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18),
-                "text:Arial_18:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new TextLayerBuilder().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18)
                         .fontWeight("bold").fontStyle("italic").letterSpacing("4"),
-                "text:Arial_18_bold_italic_letter_spacing_4:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18_bold_italic_letter_spacing_4:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new SubtitlesLayerBuilder().publicId("sample_sub_en.srt"), "subtitles:sample_sub_en.srt",
                 new SubtitlesLayerBuilder().publicId("sample_sub_he.srt").fontFamily("Arial").fontSize(40),
                 "subtitles:Arial_40:sample_sub_he.srt"};

cloudinary-core/src/test/java/com/cloudinary/transformation/LayerTest.java

@@ -72,11 +72,13 @@ public void testLayerOptions() {
                 "logo.png",
                 new Layer().resourceType("video").publicId("cat"),
                 "video:cat",
+                new TextLayer().text("Hello/World").fontFamily("Arial").fontSize(18),
+                "text:Arial_18:Hello%252FWorld",
                 new TextLayer().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18),
-                "text:Arial_18:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new TextLayer().text("Hello World, Nice to meet you?").fontFamily("Arial").fontSize(18)
                         .fontWeight("bold").fontStyle("italic").letterSpacing("4"),
-                "text:Arial_18_bold_italic_letter_spacing_4:Hello%20World%E2%80%9A%20Nice%20to%20meet%20you%3F",
+                "text:Arial_18_bold_italic_letter_spacing_4:Hello%20World%252C%20Nice%20to%20meet%20you%3F",
                 new SubtitlesLayer().publicId("sample_sub_en.srt"), "subtitles:sample_sub_en.srt",
                 new SubtitlesLayer().publicId("sample_sub_he.srt").fontFamily("Arial").fontSize(40),
                 "subtitles:Arial_40:sample_sub_he.srt"};