Skip to content

Commit dca6b14

Browse files
authored
Add quality_analysis param in upload, explicit and api.resource calls
1 parent 582029d commit dca6b14

File tree

4 files changed

+17
-2
lines changed

4 files changed

+17
-2
lines changed

cloudinary-core/src/main/java/com/cloudinary/Api.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public ApiResponse resource(String public_id, Map options) throws Exception {
117117

118118
ApiResponse response = callApi(HttpMethod.GET, Arrays.asList("resources", resourceType, type, public_id),
119119
ObjectUtils.only(options, "exif", "colors", "faces", "coordinates",
120-
"image_metadata", "pages", "phash", "max_results"), options);
120+
"image_metadata", "pages", "phash", "max_results", "quality_analysis"), options);
121121

122122
return response;
123123
}

cloudinary-core/src/main/java/com/cloudinary/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
public class Util {
1010
static final String[] BOOLEAN_UPLOAD_OPTIONS = new String[]{"backup", "exif", "faces", "colors", "image_metadata", "use_filename", "unique_filename",
11-
"eager_async", "invalidate", "discard_original_filename", "overwrite", "phash", "return_delete_token", "async"};
11+
"eager_async", "invalidate", "discard_original_filename", "overwrite", "phash", "return_delete_token", "async", "quality_analysis"};
1212

1313
@SuppressWarnings({"rawtypes", "unchecked"})
1414
public static final Map<String, Object> buildUploadParams(Map options) {

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractApiTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import java.text.SimpleDateFormat;
1414
import java.util.*;
1515

16+
import static com.cloudinary.utils.ObjectUtils.asMap;
1617
import static org.hamcrest.Matchers.*;
1718
import static org.hamcrest.core.AllOf.allOf;
1819
import static org.hamcrest.core.IsNot.not;
@@ -940,4 +941,10 @@ public void testUpdateResourcesAccessModeByTag() throws Exception {
940941
assertEquals(resource.get("access_mode"), "public");
941942
cloudinary.uploader().destroy(publicId, null);
942943
}
944+
945+
@Test
946+
public void testQualityAnalysis() throws Exception {
947+
ApiResponse result = cloudinary.api().resource(API_TEST, ObjectUtils.asMap("quality_analysis", true));
948+
assertNotNull(result.get("quality_analysis"));
949+
}
943950
}

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractUploaderTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -660,6 +660,14 @@ public void testAccessControl() throws ParseException, IOException {
660660
assertEquals("2019-03-21T22:00:00Z", accessControlResponse.get(0).get("end"));
661661
}
662662

663+
@Test
664+
public void testQualityAnalysis() throws IOException {
665+
Map result = cloudinary.uploader().upload(SRC_TEST_IMAGE, asMap("quality_analysis", true, "tags", Arrays.asList(SDK_TEST_TAG, UPLOADER_TAG)));
666+
assertNotNull(result.get("quality_analysis"));
667+
result = cloudinary.uploader().explicit(result.get("public_id").toString(), ObjectUtils.asMap("type", "upload", "resource_type", "image", "quality_analysis", true));
668+
assertNotNull(result.get("quality_analysis"));
669+
670+
}
663671
private void addToDeleteList(String type, String id){
664672
Set<String> ids = toDelete.get(type);
665673
if (ids == null){

0 commit comments

Comments
 (0)