change user agent - remove spaces. stricter layer parameter check. fix underlay method signature

Author: itaibenari

cloudinary-core/src/main/java/com/cloudinary/Transformation.java

@@ -138,7 +138,7 @@ public Transformation overlay(AbstractLayerBuilder<?> value) {
 		return param("overlay", value);
 	}
 
-	public Transformation underlay(Object value) {
+	public Transformation underlay(String value) {
 		return param("underlay", value);
 	}
 

cloudinary-core/src/main/java/com/cloudinary/transformation/TextLayerBuilder.java

@@ -107,17 +107,17 @@ public String toString() {
 	protected String textStyleIdentifier() {
 		ArrayList<String> components = new ArrayList<String>();
 
-		if (this.fontWeight != null && !this.fontWeight.equals("normal"))
+		if (StringUtils.isNotBlank(this.fontWeight) && !this.fontWeight.equals("normal"))
 			components.add(this.fontWeight);
-		if (this.fontStyle != null && !this.fontStyle.equals("normal"))
+		if (StringUtils.isNotBlank(this.fontStyle) && !this.fontStyle.equals("normal"))
 			components.add(this.fontStyle);
-		if (this.textDecoration != null && !this.textDecoration.equals("none"))
+		if (StringUtils.isNotBlank(this.textDecoration) && !this.textDecoration.equals("none"))
 			components.add(this.textDecoration);
-		if (this.textAlign != null)
+		if (StringUtils.isNotBlank(this.textAlign))
 			components.add(this.textAlign);
-		if (this.stroke != null && !this.stroke.equals("none"))
+		if (StringUtils.isNotBlank(this.stroke) && !this.stroke.equals("none"))
 			components.add(this.stroke);
-		if (this.letterSpacing != null)
+		if (StringUtils.isNotBlank(this.letterSpacing))
 			components.add("letter_spacing_" + this.letterSpacing);
 
 		if (this.fontFamily == null && this.fontSize == null && components.isEmpty()) {

cloudinary-http42/src/main/java/com/cloudinary/http42/ApiStrategy.java

@@ -91,7 +91,7 @@ public ApiResponse callApi(HttpMethod method, Iterable<String> uri, Map<String,
 			break;
 		}
 		request.setHeader("Authorization", "Basic " + Base64Coder.encodeString(apiKey + ":" + apiSecret));
-		request.setHeader("User-Agent", Cloudinary.USER_AGENT + " Apache HTTP Components/4.2");
+		request.setHeader("User-Agent", Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.2");
 
 		HttpResponse response = client.execute(request);
 

cloudinary-http42/src/main/java/com/cloudinary/http42/UploaderStrategy.java

@@ -58,7 +58,7 @@ public Map callApi(String action, Map<String, Object> params, Map options, Objec
 		}
 
 		HttpPost postMethod = new HttpPost(apiUrl);
-		postMethod.setHeader("User-Agent", Cloudinary.USER_AGENT + " Apache HTTP Components/4.2");
+		postMethod.setHeader("User-Agent", Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.2");
 
 		if (options.get("content_range") != null) {
 			postMethod.setHeader("Content-Range", (String) options.get("content_range")); 

cloudinary-http43/src/main/java/com/cloudinary/http43/ApiStrategy.java

@@ -42,7 +42,7 @@ public void init(Api api) {
 		super.init(api);
 
 		HttpClientBuilder clientBuilder = HttpClients.custom();
-		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " Apache HTTP Components/4.3");
+		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.3");
 
 		// If the configuration specifies a proxy then apply it to the client
 		if (api.cloudinary.config.proxyHost != null && api.cloudinary.config.proxyPort != 0) {

cloudinary-http43/src/main/java/com/cloudinary/http43/UploaderStrategy.java

@@ -35,7 +35,7 @@ public void init(Uploader uploader) {
 		super.init(uploader);
 
 		HttpClientBuilder clientBuilder = HttpClients.custom();
-		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " Apache HTTP Components/4.3");
+		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.3");
 
 		// If the configuration specifies a proxy then apply it to the client
 		if (cloudinary().config.proxyHost != null && cloudinary().config.proxyPort != 0) {

cloudinary-http44/src/main/java/com/cloudinary/http44/ApiStrategy.java

@@ -42,7 +42,7 @@ public void init(Api api) {
 		super.init(api);
 
 		HttpClientBuilder clientBuilder = HttpClients.custom();
-		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " Apache HTTP Components/4.4");
+		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.4");
 
 		// If the configuration specifies a proxy then apply it to the client
 		if (api.cloudinary.config.proxyHost != null && api.cloudinary.config.proxyPort != 0) {

cloudinary-http44/src/main/java/com/cloudinary/http44/UploaderStrategy.java

@@ -35,7 +35,7 @@ public void init(Uploader uploader) {
 		super.init(uploader);
 
 		HttpClientBuilder clientBuilder = HttpClients.custom();
-		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " Apache HTTP Components/4.4");
+		clientBuilder.useSystemProperties().setUserAgent(Cloudinary.USER_AGENT + " ApacheHTTPComponents/4.4");
 
 		// If the configuration specifies a proxy then apply it to the client
 		if (cloudinary().config.proxyHost != null && cloudinary().config.proxyPort != 0) {