Better object property detection

dannyv-cloudinary · dannyv-cloudinary · commit 0a44a5b1b04c · 2022-12-13T15:11:07.000+02:00
diff --git a/lib/api_client/execute_request.js b/lib/api_client/execute_request.js
@@ -70,8 +70,8 @@ function execute_request(method, params, auth, api_url, callback, options = {})
     const sanitized_request_options = {...request_options};
 
     if (hide_sensitive === true){
-      if (sanitized_request_options.auth) { delete sanitized_request_options.auth; }
-      if (sanitized_request_options.headers) { delete sanitized_request_options.headers.Authorization; }
+      if ("auth" in sanitized_request_options) { delete sanitized_request_options.auth; }
+      if ("Authorization" in sanitized_request_options.headers) { delete sanitized_request_options.headers.Authorization; }
     }
 
     if (includes([200, 400, 401, 403, 404, 409, 420, 500], res.statusCode)) {

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,8 @@ function execute_request(method, params, auth, api_url, callback, options = {})`
`70`	`70`	`const sanitized_request_options = {...request_options};`
`71`	`71`
`72`	`72`	`if (hide_sensitive === true){`
`73`		`- if (sanitized_request_options.auth) { delete sanitized_request_options.auth; }`
`74`		`- if (sanitized_request_options.headers) { delete sanitized_request_options.headers.Authorization; }`
	`73`	`+ if ("auth" in sanitized_request_options) { delete sanitized_request_options.auth; }`
	`74`	`+ if ("Authorization" in sanitized_request_options.headers) { delete sanitized_request_options.headers.Authorization; }`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`if (includes([200, 400, 401, 403, 404, 409, 420, 500], res.statusCode)) {`