fix: upload_chunked_stream works properly with more than 2 chunks (#673)

* fix: upload_chunked_stream works properly with more than 2 chunks

Author: cloudinary-pkoniu

lib/uploader.js

@@ -102,8 +102,10 @@ class Chunkable extends Writable {
       this.emit('ready', this.buffer, false, (active) => {
         this.active = active;
         if (this.active) {
-          this.buffer = data.slice(grab);
-          done();
+          // Start processing the remaining data
+          const remaining = data.slice(grab);
+          this.buffer = Buffer.alloc(0); // Reset the buffer
+          this._write(remaining, encoding, done); // Process the remaining data
         }
       });
     }

test/.resources/big-image.jpg

@@ -14,6 +14,7 @@ const cloneDeep = require('lodash/cloneDeep');
 const assert = require('assert');
 
 const IMAGE_FILE = helper.IMAGE_FILE;
+const LARGE_IMAGE_FILE = helper.LARGE_IMAGE_FILE;
 const LARGE_RAW_FILE = helper.LARGE_RAW_FILE;
 const LARGE_VIDEO = helper.LARGE_VIDEO;
 const EMPTY_IMAGE = helper.EMPTY_IMAGE;
@@ -1002,9 +1003,8 @@ describe("uploader", function () {
     });
   });
   it("should successfully upload with pipes", function (done) {
-    var file_reader, upload;
     this.timeout(TIMEOUT.LONG);
-    upload = cloudinary.v2.uploader.upload_stream({
+    const upload = cloudinary.v2.uploader.upload_stream({
       tags: UPLOAD_TAGS
     }, function (error, result) {
       var expected_signature;
@@ -1017,8 +1017,19 @@ describe("uploader", function () {
       expect(result.signature).to.eql(expected_signature);
       done();
     });
-    file_reader = fs.createReadStream(IMAGE_FILE);
-    file_reader.pipe(upload);
+    fs.createReadStream(IMAGE_FILE).pipe(upload);
+  });
+  it("should successfully upload in chunks with pipes", (done) => {
+    this.timeout(TIMEOUT.LONG);
+    const upload = cloudinary.v2.uploader.upload_chunked_stream({
+      chunk_size: 7000000,
+      timeout: TIMEOUT.LONG
+    }, (error, result) => {
+      assert.strictEqual(error, undefined);
+      assert.ok(result.public_id);
+      done();
+    });
+    fs.createReadStream(LARGE_IMAGE_FILE).pipe(upload);
   });
   it("should fail with http.Agent (non secure)", function () {
     this.timeout(TIMEOUT.LONG);

test/integration/api/uploader/uploader_spec.js

@@ -19,6 +19,7 @@ exports.libPath = libPath;
 const api_http = String(config().upload_prefix).startsWith('http:') ? http : https;
 
 exports.IMAGE_FILE = "test/.resources/logo.png";
+exports.LARGE_IMAGE_FILE = "test/.resources/big-image.jpg";
 exports.LARGE_RAW_FILE = "test/.resources/TheCompleteWorksOfShakespeare.mobi";
 exports.LARGE_VIDEO = "test/.resources/CloudBookStudy-HD.mp4";
 exports.EMPTY_IMAGE = "test/.resources/empty.gif";