Fixed open linting issues (#279)

* Added missing dangling commas
* General Formatting fixes
* import ordering fixes
* newline-after-import fixes
* Consistent returns from functions
* Removed bitwise operators from samples
* No unused variables
* Disallow variable declarations from shadowing variables declared in the outer scope

Author: RTLcoil

babel.config.js

@@ -3,10 +3,10 @@ const presets = [
     [
       "env",
       {
-        targets: { node: "4" }
-      }
+        targets: { node: "4" },
+      },
     ],
-    "stage-0"
+    "stage-0",
   ],
 ];
 const plugins = ["transform-object-rest-spread"];

samples/basic/basic.js

@@ -1,10 +1,7 @@
-var dotenv = require('dotenv');
-dotenv.load();
-
+require('dotenv').load();
 var fs = require('fs');
 var cloudinary = require('cloudinary').v2;
 
-
 var uploads = {};
 
 // set your env variable CLOUDINARY_URL or set the following configuration
@@ -38,7 +35,7 @@ var upload_stream = cloudinary.uploader.upload_stream({ tags: 'basic_sample' },
   console.log("* " + image.url);
   waitForAllUploads("pizza3", err, image);
 });
-var file_reader = fs.createReadStream('pizza.jpg').pipe(upload_stream);
+fs.createReadStream('pizza.jpg').pipe(upload_stream);
 
 
 // File upload (example for promise api)
@@ -72,7 +69,7 @@ cloudinary.uploader.upload('pizza.jpg', { tags: 'basic_sample', public_id: 'my_f
 // Eager Transformations:
 // Applied as soon as the file is uploaded, instead of lazily applying them when accessed by your site's visitors.
 var eager_options = {
-  width: 200, height: 150, crop: 'scale', format: 'jpg'
+  width: 200, height: 150, crop: 'scale', format: 'jpg',
 };
 cloudinary.uploader.upload("lake.jpg", { tags: "basic_sample", public_id: "blue_lake", eager: eager_options }, function (err, image) {
   // "eager" parameter accepts a hash (or just a single item). You can pass

samples/photo_album/config/schema.js

@@ -1,12 +1,13 @@
 var Schema = require('jugglingdb').Schema;
+
 var schema = new Schema('memory');
 // Uncomment if you want to use mongodb adapter
 // var schema = new Schema('mongodb');
 
 // Define models
-var Photo = schema.define('Photo', {
+schema.define('Photo', {
   title: { type: String, length: 255 },
-  image: { type: JSON }
+  image: { type: JSON },
 });
 
 module.exports = schema;

samples/photo_album/controllers/photos_controller.js

@@ -1,8 +1,10 @@
 var cloudinary = require('cloudinary').v2;
-var schema = require('../config/schema');
 var crypto = require('crypto');
-var Photo = schema.models.Photo;
 var multipart = require('connect-multiparty');
+var schema = require('../config/schema');
+
+var Photo = schema.models.Photo;
+
 var multipartMiddleware = multipart();
 
 function index(req, res) {
@@ -19,7 +21,7 @@ function add_through_server(req, res) {
   })
     .finally(function () {
       res.render('photos/add', {
-        photo: photo
+        photo: photo,
       });
     });
 }
@@ -48,7 +50,7 @@ function create_through_server(req, res) {
       // Save photo with image metadata
       return photo.save();
     })
-    .then(function (photo) {
+    .then(function () {
       console.log('** photo saved');
     })
     .finally(function () {
@@ -67,7 +69,7 @@ function add_direct(req, res) {
     .finally(function () {
       res.render('photos/add_direct', {
         photo: photo,
-        cloudinary_cors: cloudinary_cors
+        cloudinary_cors: cloudinary_cors,
       });
     });
 }
@@ -95,6 +97,7 @@ function add_direct_unsigned(req, res) {
       if (!preset.settings.return_delete_token) {
         return cloudinary.api.update_upload_preset(preset_name, { return_delete_token: true });
       }
+      return undefined;
     })
     .catch(function (err) {
       // Creating an upload preset is done here only for demo purposes.
@@ -104,15 +107,15 @@ function add_direct_unsigned(req, res) {
         unsigned: true,
         name: preset_name,
         folder: "preset_folder",
-        return_delete_token: true
+        return_delete_token: true,
       });
     })
     .finally(function (preset) {
       res.render('photos/add_direct_unsigned',
         {
           photo: photo,
           cloudinary_cors: cloudinary_cors,
-          preset_name: preset_name
+          preset_name: preset_name,
         });
     });
 }
@@ -138,7 +141,7 @@ function create_direct(req, res) {
     photo.image = image.toJSON();
     console.dir(photo.image);
   }
-  photo.save().then(function (photo) {
+  photo.save().then(function () {
     console.log('** photo saved');
   })
     .catch(function (err) {

samples/photo_album/server.js

@@ -1,7 +1,8 @@
 // Load environment variables
-var dotenv = require('dotenv');
-dotenv.load();
+require('dotenv').load();
+
 var cloudinary = require('cloudinary').v2;
+
 if (typeof (process.env.CLOUDINARY_URL) === 'undefined') {
   console.warn('!! cloudinary config is undefined !!');
   console.warn('export CLOUDINARY_URL or set dotenv file');
@@ -11,19 +12,17 @@ if (typeof (process.env.CLOUDINARY_URL) === 'undefined') {
 }
 console.log('-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --');
 var path = require('path');
-// Start express server
-var schema = require('./config/schema');
 var express = require('express');
 var engine = require('ejs-locals');
-var app = express();
 var bodyParser = require('body-parser');
 var methodOverride = require('method-override');
+require('./config/schema');
+
+// Start express server
+var app = express();
 app.use(bodyParser.json());
 app.use(bodyParser.urlencoded({ extended: false }));
-
 app.use(methodOverride());
-
-
 app.use(express.static(path.join(__dirname, '/public')));
 app.set('views', path.join(__dirname, '/views/'));
 app.use('/node_modules', express.static(path.join(__dirname, '/node_modules')));
@@ -34,13 +33,14 @@ app.set('view engine', 'ejs');
 wirePreRequest(app);
 // Wire request controllers
 var photosController = require('./controllers/photos_controller');
+
 photosController.wire(app);
 
 // Wire request 'post' actions
 wirePostRequest(app);
 
-function wirePreRequest(app) {
-  app.use(function (req, res, next) {
+function wirePreRequest(application) {
+  application.use(function (req, res, next) {
     console.log(req.method + " " + req.url);
     res.locals.req = req;
     res.locals.res = res;
@@ -55,18 +55,19 @@ function wirePreRequest(app) {
   });
 }
 
-function wirePostRequest(app) {
-  app.use(function (err, req, res, next) {
-    if (err.message && (~err.message.indexOf('not found') || (~err.message.indexOf('Cast to ObjectId failed')))) {
+function wirePostRequest(application) {
+  application.use(function (err, req, res, next) {
+    if (err.message && (err.message.indexOf('not found') !== -1 || err.message.indexOf('Cast to ObjectId failed') !== -1)) {
       return next();
     }
     console.log('error (500) ' + err.message);
     console.log(err.stack);
-    if (~err.message.indexOf('CLOUDINARY_URL')) {
+    if (err.message.indexOf('CLOUDINARY_URL') !== -1) {
       res.status(500).render('errors/dotenv', { error: err });
     } else {
       res.status(500).render('errors/500', { error: err });
     }
+    return undefined;
   });
 }
 
@@ -75,7 +76,7 @@ app.use(function (req, res, next) {
   console.log('error (404)');
   res.status(404).render('errors/404', {
     url: req.url,
-    error: 'Not found'
+    error: 'Not found',
   });
 });