feat: add allow_dynamic_list_values parameter support to add_metadata… (#724)

* feat: add allow_dynamic_list_values parameter support to add_metadata_field and update_metadata_field methods

* test: add test for updating metadata field with allow_dynamic_list_values

Author: esguerrat

lib/api.js

@@ -546,7 +546,7 @@ exports.update_resources_access_mode_by_ids = function update_resources_access_m
  * @return {Object}
  */
 exports.add_metadata_field = function add_metadata_field(field, callback, options = {}) {
-  const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions");
+  const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "allow_dynamic_list_values");
   options.content_type = "json";
   return call_api("post", ["metadata_fields"], params, callback, options);
 };
@@ -613,7 +613,7 @@ exports.metadata_field_by_field_id = function metadata_field_by_field_id(externa
  * @return {Object}
  */
 exports.update_metadata_field = function update_metadata_field(external_id, field, callback, options = {}) {
-  const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "default_disabled");
+  const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "default_disabled", "allow_dynamic_list_values");
   options.content_type = "json";
   return call_api("put", ["metadata_fields", external_id], params, callback, options);
 };

test/integration/api/admin/structured_metadata_spec.js

@@ -211,7 +211,8 @@ describe("structured metadata api", function () {
         },
         external_id: EXTERNAL_ID_SET,
         label: EXTERNAL_ID_SET,
-        type: 'set'
+        type: 'set',
+        allow_dynamic_list_values: true
       };
       return api.add_metadata_field(metadata).then((result) => {
         expect(result).to.beAMetadataField();
@@ -221,36 +222,39 @@ describe("structured metadata api", function () {
           external_id: EXTERNAL_ID_SET,
           label: EXTERNAL_ID_SET,
           type: 'set',
-          mandatory: false
+          mandatory: false,
+          allow_dynamic_list_values: true
         }]).to.beAMetadataField();
       });
     });
   });
 
   describe("update_metadata_field", function () {
     it("should update metadata field by external id", function () {
-      const newLabel = 'update_metadata_test_new_label' + EXTERNAL_ID_GENERAL;
-      const newDefaultValue = 'update_metadata_test_new_default_value' + EXTERNAL_ID_GENERAL;
+      const newLabel = 'update_metadata_test_new_label' + EXTERNAL_ID_SET;
       const updatedMetadata = {
         external_id: EXTERNAL_ID_SET,
         label: newLabel,
-        type: 'integer',
-        mandatory: true,
-        default_value: newDefaultValue
+        type: "set",
+        mandatory: false,
+        allow_dynamic_list_values: true
       };
-      return api.update_metadata_field(EXTERNAL_ID_GENERAL, updatedMetadata)
+      return api.update_metadata_field(EXTERNAL_ID_SET, updatedMetadata)
         .then((result) => {
           expect(result).to.beAMetadataField();
-          return api.metadata_field_by_field_id(EXTERNAL_ID_GENERAL);
+          return api.metadata_field_by_field_id(EXTERNAL_ID_SET);
         })
         .then((result) => {
-          expect([result, {
-            external_id: EXTERNAL_ID_GENERAL,
-            label: newLabel,
-            type: 'string',
-            mandatory: true,
-            default_value: newDefaultValue
-          }]).to.beAMetadataField();
+          expect([
+            result,
+            {
+              external_id: EXTERNAL_ID_SET,
+              label: newLabel,
+              type: "set",
+              mandatory: false,
+              allow_dynamic_list_values: true
+            }
+          ]).to.beAMetadataField();
         });
     });
   });

types/index.d.ts

@@ -706,6 +706,7 @@ declare module 'cloudinary' {
 
     export interface MetadataFieldApiOptions {
         external_id?: string;
+        allow_dynamic_list_values?: boolean;
         type?: string;
         label?: string;
         mandatory?: boolean;