Skip to content

Commit 4004b63

Browse files
committed
fix: change tracking url param from _a to _a
1 parent a49d3b2 commit 4004b63

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib-es5/utils/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,7 @@ function url(public_id) {
917917
if (resultUrl.indexOf('?') >= 0) {
918918
appender = '&';
919919
}
920-
resultUrl = `${resultUrl}${appender}_s=${sdkAnalyticsSignature}`;
920+
resultUrl = `${resultUrl}${appender}_a=${sdkAnalyticsSignature}`;
921921
}
922922

923923
return resultUrl;

lib/utils/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,7 @@ function url(public_id, options = {}) {
847847
if (resultUrl.indexOf('?') >= 0) {
848848
appender = '&';
849849
}
850-
resultUrl = `${resultUrl}${appender}_s=${sdkAnalyticsSignature}`;
850+
resultUrl = `${resultUrl}${appender}_a=${sdkAnalyticsSignature}`;
851851
}
852852

853853
return resultUrl;

test/unit/sdkAnalytics/imageTagWithAnalytics.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('Tests for sdk analytics through image tag', function () {
4949
urlAnalytics: true
5050
});
5151

52-
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_s=AMAlhAM0`);
52+
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_a=AMAlhAM0`);
5353
});
5454

5555
it('Reads from process.versions and package.json (Mocked) - Responsive', () => {
@@ -63,7 +63,7 @@ describe('Tests for sdk analytics through image tag', function () {
6363
urlAnalytics: true
6464
});
6565

66-
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_s=AMAlhAMA`);
66+
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_a=AMAlhAMA`);
6767
});
6868

6969
it('Reads from tracked analytics configuration', () => {
@@ -80,6 +80,6 @@ describe('Tests for sdk analytics through image tag', function () {
8080

8181
});
8282

83-
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_s=AXAEzGT0`);
83+
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_a=AXAEzGT0`);
8484
});
8585
});

0 commit comments

Comments
 (0)