Skip to content

Commit 6a81cdc

Browse files
committed
feat: add option to configure tracked analytics
Add similar behavious as in @cloudinary/url-gen for configuring tracked analytics and update tests. Closes #590
1 parent 352a5b5 commit 6a81cdc

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

lib/utils/index.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -827,11 +827,17 @@ function url(public_id, options = {}) {
827827
}
828828

829829
let urlAnalytics = ensureOption(options, 'urlAnalytics', false);
830+
let trackedAnalytics = ensureOption(options, 'trackedAnalytics', false);
830831

831-
if (urlAnalytics === true) {
832+
if (urlAnalytics === true || trackedAnalytics) {
832833
let sdkVersions = getSDKVersions();
833-
let analyticsOptions = getAnalyticsOptions(Object.assign({}, options, sdkVersions));
834834

835+
if (trackedAnalytics) {
836+
sdkVersions = trackedAnalytics;
837+
sdkVersions.urlAnalytics = true;
838+
}
839+
840+
let analyticsOptions = getAnalyticsOptions(Object.assign({}, options, sdkVersions));
835841
let sdkAnalyticsSignature = getSDKAnalyticsSignature(analyticsOptions);
836842

837843
// url might already have a '?' query param

test/unit/sdkAnalytics/imageTagWithAnalytics.spec.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,21 @@ describe('Tests for sdk analytics through image tag', function () {
6565

6666
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_s=AMAlhAMA`);
6767
});
68+
69+
it('Reads from tracked analytics configuration', () => {
70+
process.versions = {
71+
node: '12.0.0'
72+
};
73+
74+
let imgStr = cloudinary.image("hello", {
75+
format: "png",
76+
trackedAnalytics: {
77+
sdkCode: "X",
78+
sdkSemver: "7.3.0",
79+
techVersion: "3.4.7"
80+
}
81+
});
82+
83+
expect(imgStr).to.contain(`src='http://res.cloudinary.com/${TEST_CLOUD_NAME}/image/upload/hello.png?_s=AXAEzGT0`);
84+
});
6885
});

0 commit comments

Comments
 (0)