chore: dev dependencies cleanup + new node version support in CI

* chore: upgraded nyc and jsdoc

* chore: include node 20+22 in CI

* chore: ignore vscode files

* chore: using [email protected]

* fix: fixed specs

* fix: fixed specs

* fix: fixed specs

Author: cloudinary-pkoniu

.gitignore

@@ -14,3 +14,4 @@ coverage
 tools/cloudinary_url.sh
 package-lock.json
 npm-debug.log
+.vscode/

.travis.yml

@@ -1,5 +1,4 @@
 language: node_js
-nvm:
 dist: focal
 matrix:
   include:
@@ -15,6 +14,11 @@ matrix:
     script: npm run test-with-temp-cloud
   - node_js: "18"
     script: npm run test-with-temp-cloud
+  - node_js: "20"
+    script: npm run test-with-temp-cloud
+  - node_js: "22"
+    script: npm run test-with-temp-cloud
+
 
 notifications:
   email:

lib/utils/analytics/getSDKVersions.js

@@ -26,7 +26,8 @@ function getSDKVersions(useSDKVersion = 'default', useNodeVersion = 'default') {
   const sdkSemver = useSDKVersion === 'default' ? readSdkSemver() : useSDKVersion;
 
   // allow to pass a custom techVersion (Node version)
-  const techVersion = useNodeVersion === 'default' ? process.versions.node : useNodeVersion;
+  const version = process.version.slice(1);
+  const techVersion = useNodeVersion === 'default' ? version : useNodeVersion;
 
   const product = 'A';
 

package.json

@@ -15,9 +15,9 @@
     "q": "^1.5.1"
   },
   "devDependencies": {
+    "@types/expect.js": "^0.3.29",
     "@types/mocha": "^7.0.2",
     "@types/node": "^13.5.0",
-    "@types/expect.js": "^0.3.29",
     "date-fns": "^2.16.1",
     "dotenv": "4.x",
     "dtslint": "^0.9.1",
@@ -26,12 +26,11 @@
     "eslint-plugin-import": "^2.20.2",
     "expect.js": "0.3.x",
     "glob": "^7.1.6",
-    "jsdoc": "3.5.5",
+    "jsdoc": "^3.6.11",
     "jsdom": "^9.12.0",
     "jsdom-global": "2.1.1",
     "mocha": "^6.2.3",
-    "mock-fs": "^4.12.0",
-    "nyc": "^13.3.0",
+    "nyc": "^14.1.1",
     "rimraf": "^3.0.0",
     "sinon": "^6.1.4",
     "typescript": "^3.7.5",

test/unit/sdkAnalytics/imageTagWithAnalytics.spec.js

@@ -1,5 +1,4 @@
 const path = require('path');
-const mock = require('mock-fs');
 const assert = require("assert");
 const sinon = require("sinon");
 const fs = require('fs');
@@ -11,35 +10,21 @@ const TEST_CLOUD_NAME = require('../../testUtils/testConstants').TEST_CLOUD_NAME
 describe('SDK url analytics', () => {
   let processVersions = {};
 
-  before(() => {
+  beforeEach(() => {
     cloudinary.config(true); // reset
-
-    processVersions = process.versions;
-    delete process.versions;
-  });
-
-  after(() => {
-    process.versions = processVersions;
+    cloudinary.config({
+      techVersion: '12.0.0'
+    });
   });
 
   describe('when package json is available', () => {
-    before(() => {
-      const file = path.join(__dirname, '../../../package.json');
-
-      mock({
-        [file]: '{"version":"1.24.0"}'
+    beforeEach(() => {
+      cloudinary.config({
+        sdkSemver: '1.24.0'
       });
     });
 
-    after(() => {
-      mock.restore();
-    });
-
     it('can be turned off via options', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const imgStr = cloudinary.image("hello", {
         format: "png",
         analytics: false
@@ -49,10 +34,6 @@ describe('SDK url analytics', () => {
     });
 
     it('defaults to true even if analytics is not passed as an option', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const imgStr = cloudinary.image("hello", {
         format: "png"
       });
@@ -61,10 +42,6 @@ describe('SDK url analytics', () => {
     });
 
     it('reads from process.versions and package.json (Mocked)', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const imgStr = cloudinary.image("hello", {
         format: "png",
         analytics: true
@@ -74,12 +51,8 @@ describe('SDK url analytics', () => {
     });
 
     it('reads from process.versions and package.json (Mocked) - Responsive', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const imgStr = cloudinary.image("hello", {
-        format: "png",
+        format: 'png',
         responsive: true,
         analytics: true
       });
@@ -88,9 +61,7 @@ describe('SDK url analytics', () => {
     });
 
     it('reads from tracked analytics configuration', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
+      cloudinary.config(true); // reset
 
       const imgStr = cloudinary.image("hello", {
         format: "png",
@@ -105,10 +76,6 @@ describe('SDK url analytics', () => {
     });
 
     it('should still accept analytics param passed as camel case', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const imgStr = cloudinary.image("hello", {
         format: "png",
         urlAnalytics: true,
@@ -123,10 +90,6 @@ describe('SDK url analytics', () => {
 
     describe('with two different casings', () => {
       it('should treat camel case analytics param as more important than snake case', () => {
-        process.versions = {
-          node: '12.0.0'
-        };
-
         const imgStr1 = cloudinary.image("hello", {
           format: "png",
           urlAnalytics: true,
@@ -157,17 +120,15 @@ describe('SDK url analytics', () => {
       const enoent = new Error('ENOENT');
       enoent.code = 'ENOENT';
       sinon.stub(fs, 'readFileSync').throws(enoent);
+
+      cloudinary.config(true); // reset
     });
 
     after(() => {
       sinon.restore();
     });
 
     it('uses 0.0.0 as fallback sdk semver', () => {
-      process.versions = {
-        node: '12.0.0'
-      };
-
       const urlWithToken = cloudinary.url("hello", {
         format: "png",
         analytics: true