Escape all instances of single and double quotes, not just the first - fixes #504 (#505)

Co-authored-by: Adam Nelson <[email protected]>

Author: spudstuff

lib-es5/utils/index.js

@@ -1261,7 +1261,7 @@ function join_pair(key, value) {
  * @return {*} Encoded string or original value if not a string
  */
 function escapeQuotes(value) {
-  return isString(value) ? value.replace('"', '"').replace("'", ''') : value;
+  return isString(value) ? value.replace(/\"/g, '"').replace(/\'/g, ''') : value;
 }
 
 /**

lib/utils/index.js

@@ -1158,7 +1158,7 @@ function join_pair(key, value) {
  * @return {*} Encoded string or original value if not a string
  */
 function escapeQuotes(value) {
-  return isString(value) ? value.replace('"', '"').replace("'", ''') : value;
+  return isString(value) ? value.replace(/\"/g, '"').replace(/\'/g, ''') : value;
 }
 
 /**

test/unit/tags/image_spec.js

@@ -121,8 +121,8 @@ describe('image helper', function () {
   });
   it("should escape quotes in html attributes", function() {
     expect(cloudinary.image("sample.jpg", {
-      alt: "asdfg\"'asdf"
-    })).to.eql(`<img src='${UPLOAD_PATH}/sample.jpg' alt='asdfg&#34;&#39;asdf'/>`);
+      alt: "here 'is' my \"alt\" escaped"
+    })).to.eql(`<img src='${UPLOAD_PATH}/sample.jpg' alt='here &#39;is&#39; my &#34;alt&#34; escaped'/>`);
   });
 
   describe(":client_hints", function () {