Skip to content

Commit b9a0ea2

Browse files
committed
add support for keyframe-interval (ki) video manipulation parameter
1 parent 293e275 commit b9a0ea2

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/utils.coffee

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ exports.generate_transformation_string = (options) ->
342342
e: normalize_expression(effect)
343343
fl: flags
344344
h: normalize_expression(height)
345+
ki: normalize_expression(utils.option_consume(options, "keyframe_interval"))
345346
l: overlay
346347
o: normalize_expression(utils.option_consume(options, "opacity"))
347348
q: normalize_expression(utils.option_consume(options, "quality"))

test/video_spec.coffee

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ describe "video tag helper", ->
3333
html_width : "200",
3434
video_codec : {codec: "h264"},
3535
audio_codec : "acc",
36-
start_offset: 3
36+
start_offset: 3,
37+
keyframe_interval: "2.0"
3738
}
38-
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,so_3,vc_h264/movie"
39+
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,ki_2.0,so_3,vc_h264/movie"
3940
expect(cloudinary.video("movie", options)).to.eql(
4041
"<video height='100' poster='#{expected_url}.jpg' src='#{expected_url}.mp4' width='200'></video>")
4142

@@ -51,15 +52,15 @@ describe "video tag helper", ->
5152
delete options['html_width']
5253
options['width'] = 250
5354
options['crop'] = 'scale'
54-
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,c_scale,so_3,vc_h264,w_250/movie"
55+
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,c_scale,ki_2.0,so_3,vc_h264,w_250/movie"
5556
expect(cloudinary.video("movie", options)).to.eql(
5657
"<video poster='#{expected_url}.jpg' width='250'>" +
5758
"<source src='#{expected_url}.webm' type='video/webm'>" +
5859
"<source src='#{expected_url}.mp4' type='video/mp4'>" +
5960
"<source src='#{expected_url}.ogv' type='video/ogg'>" +
6061
"</video>")
6162

62-
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,c_fit,so_3,vc_h264,w_250/movie"
63+
expected_url = VIDEO_UPLOAD_PATH + "ac_acc,c_fit,ki_2.0,so_3,vc_h264,w_250/movie"
6364
options['crop'] = 'fit'
6465
expect(cloudinary.video("movie", options)).to.eql(
6566
"<video poster='#{expected_url}.jpg'>" +

0 commit comments

Comments
 (0)