Skip to content

Commit d92396b

Browse files
RTLcoilstrausr
authored andcommitted
Add live parameter to create_upload_preset and update_upload_preset
1 parent f8a0b7f commit d92396b

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

lib-es5/api.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ exports.update_upload_preset = function update_upload_preset(name, callback) {
428428
var params = void 0,
429429
uri = void 0;
430430
uri = ["upload_presets", name];
431-
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "unsigned", "disallow_public_id"));
431+
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "unsigned", "disallow_public_id", "live"));
432432
return call_api("put", uri, params, callback, options);
433433
};
434434

@@ -438,7 +438,7 @@ exports.create_upload_preset = function create_upload_preset(callback) {
438438
var params = void 0,
439439
uri = void 0;
440440
uri = ["upload_presets"];
441-
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "name", "unsigned", "disallow_public_id"));
441+
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "name", "unsigned", "disallow_public_id", "live"));
442442
return call_api("post", uri, params, callback, options);
443443
};
444444

lib/api.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,14 +343,14 @@ exports.delete_upload_preset = function delete_upload_preset(name, callback, opt
343343
exports.update_upload_preset = function update_upload_preset(name, callback, options = {}) {
344344
let params, uri;
345345
uri = ["upload_presets", name];
346-
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "unsigned", "disallow_public_id"));
346+
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "unsigned", "disallow_public_id", "live"));
347347
return call_api("put", uri, params, callback, options);
348348
};
349349

350350
exports.create_upload_preset = function create_upload_preset(callback, options = {}) {
351351
let params, uri;
352352
uri = ["upload_presets"];
353-
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "name", "unsigned", "disallow_public_id"));
353+
params = utils.merge(utils.clear_blank(utils.build_upload_params(options)), only(options, "name", "unsigned", "disallow_public_id", "live"));
354354
return call_api("post", uri, params, callback, options);
355355
};
356356

test/api_spec.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,7 @@ describe("api", function () {
654654
colors: true,
655655
unsigned: true,
656656
disallow_public_id: true,
657+
live: true
657658
});
658659
var expectedPath="/.*\/upload_presets/"+API_TEST_UPLOAD_PRESET3+"$";
659660
sinon.assert.calledWith(request, sinon.match({
@@ -663,6 +664,19 @@ describe("api", function () {
663664
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('colors', 1 , "colors=1")));
664665
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('unsigned', true , "unsigned=true")));
665666
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('disallow_public_id', true , "disallow_public_id=true")));
667+
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('live', true, "live=true")));
668+
});
669+
});
670+
it("should allow creating upload_presets", function () {
671+
return helper.mockPromise(function (xhr, write) {
672+
cloudinary.v2.api.create_upload_preset({
673+
folder: "upload_folder",
674+
unsigned: true,
675+
tags: UPLOAD_TAGS,
676+
live: true
677+
});
678+
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('unsigned', true, "unsigned=true")));
679+
sinon.assert.calledWith(write, sinon.match(helper.apiParamMatcher('live', true, "live=true")));
666680
});
667681
});
668682
});

0 commit comments

Comments
 (0)