feat: allow deleting resources by asset_ids (#701)

* feat: allow deleting resources by asset_ids

* add URI array

* add function to the list of v2 adapters

* add the typescript functions

* remove .only

---------

Co-authored-by: Tia Esguerra <[email protected]>

Author: cloudinary-pkoniu

lib/api.js

@@ -171,6 +171,13 @@ exports.delete_resources = function delete_resources(public_ids, callback, optio
   }), callback, options);
 };
 
+exports.delete_resources_by_asset_ids = function delete_resources_by_asset_ids(asset_ids, callback, options = {}) {
+  let uri = ["resources"]
+  return call_api("delete", uri, deleteResourcesParams(options, {
+    "asset_ids[]": asset_ids
+  }), callback, options);
+};
+
 exports.delete_resources_by_prefix = function delete_resources_by_prefix(prefix, callback, options = {}) {
   let resource_type, type, uri;
   resource_type = options.resource_type || "image";

lib/v2/api.js

@@ -18,6 +18,7 @@ v1_adapters(exports, api, {
   restore_by_asset_ids: 1,
   update: 1,
   delete_resources: 1,
+  delete_resources_by_asset_ids: 1,
   delete_resources_by_prefix: 1,
   delete_resources_by_tag: 1,
   delete_all_resources: 0,

test/integration/api/admin/api_spec.js

@@ -583,6 +583,26 @@ describe("api", function () {
         expect(error.http_code).to.eql(404);
       });
     });
+    it("should allow deleting resources by asset_ids", function () {
+      this.timeout(TIMEOUT.MEDIUM);
+      return uploadImage({
+        public_id: PUBLIC_ID_3,
+        tags: UPLOAD_TAGS
+      }).then(
+        () => cloudinary.v2.api.resource(PUBLIC_ID_3)
+      ).then(function (resource) {
+        expect(resource).not.to.eql(void 0);
+        console.log(resource);
+        return cloudinary.v2.api.delete_resources_by_asset_ids([resource.asset_id]);
+      }).then(
+        () => cloudinary.v2.api.resource(PUBLIC_ID_3)
+      ).then(() => {
+        expect().fail();
+      }).catch(function ({error}) {
+        expect(error).to.be.an(Object);
+        expect(error.http_code).to.eql(404);
+      });
+    });
     describe("delete_resources_by_prefix", function () {
       callReusableTest("accepts next_cursor", cloudinary.v2.api.delete_resources_by_prefix, "prefix_foobar");
       return it("should allow deleting resources by prefix", function () {

types/index.d.ts

@@ -1011,6 +1011,10 @@ declare module 'cloudinary' {
 
             function delete_resources(value: string[], options?: AdminAndResourceOptions, callback?: ResponseCallback): Promise<any>;
 
+             function delete_resources_by_asset_ids(asset_ids: string[], callback?: ResponseCallback): Promise<ResourceApiResponse>;
+
+            function delete_resources_by_asset_ids(asset_ids: string[], options?: AdminAndResourceOptions, callback?: ResponseCallback): Promise<ResourceApiResponse>;
+
             function delete_resources_by_prefix(prefix: string, options?: AdminAndResourceOptions, callback?: ResponseCallback): Promise<any>;
 
             function delete_resources_by_prefix(prefix: string, callback?: ResponseCallback): Promise<any>;