Merge pull request #625 from cloudinary/on-success-script-for-upload

feat: added support for on_success script for uploader_spec.js

Author: cloudinary-pkoniu

lib/utils/index.js

@@ -371,7 +371,8 @@ function build_upload_params(options) {
     quality_override: options.quality_override,
     accessibility_analysis: utils.as_safe_bool(options.accessibility_analysis),
     use_asset_folder_as_public_id_prefix: utils.as_safe_bool(options.use_asset_folder_as_public_id_prefix),
-    visual_search: utils.as_safe_bool(options.visual_search)
+    visual_search: utils.as_safe_bool(options.visual_search),
+    on_success: options.on_success
   };
   return utils.updateable_resource_params(options, params);
 }

test/integration/api/uploader/uploader_spec.js

@@ -652,6 +652,30 @@ describe("uploader", function () {
     });
   });
 
+  describe('when passing on_success in parameters', () => {
+    var spy, xhr;
+    spy = void 0;
+    xhr = void 0;
+    before(function () {
+      xhr = sinon.useFakeXMLHttpRequest();
+      spy = sinon.spy(ClientRequest.prototype, 'write');
+    });
+    after(function () {
+      spy.restore();
+      return xhr.restore();
+    });
+
+    it('should pass its value to the upload api', () => {
+      cloudinary.v2.uploader.upload(IMAGE_FILE, {
+        on_success: 'current_asset.update({tags: ["autocaption"]});'
+      });
+
+      expect(spy.calledWith(sinon.match((arg) => {
+        return arg.toString().match(/on_success='current_asset.update({tags: ["autocaption"]});'/);
+      })));
+    });
+  });
+
   describe("upload_chunked", function () {
     this.timeout(TIMEOUT.LONG * 10);
     it("should specify chunk size", function (done) {