Merge pull request #125 from cloudinary/hotfix/sync-status

Avoid key collision

Author: pereirinha

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php

@@ -109,7 +109,7 @@ public function is_synced( $post_id ) {
 			return true;
 		}
 
-		if ( apply_filters( 'cloudinary_flag_sync', '__return_false' ) ) {
+		if ( apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {
 			update_post_meta( $post_id, Sync::META_KEYS['syncing'], true );
 		}
 

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-upgrade.php

@@ -165,6 +165,7 @@ function ( $val ) use ( $media ) {
 
 		// Flag the download
 		update_post_meta( $attachment_id, Sync::META_KEYS['downloading'], true );
+		delete_post_meta( $attachment_id, Sync::META_KEYS['syncing'] );
 
 		if ( ! defined( 'DOING_BULK_SYNC' ) ) {
 			$this->sync->managers['upload']->add_to_sync( $attachment_id ); // Auto sync if upgrading outside of bulk sync.