Merge pull request #199 from cloudinary/fix/transformation-checkbox-unclarity

Fix labels in post with clearer ones

Author: pereirinha

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/css/cloudinary.css

@@ -39,7 +39,6 @@
 				}
 
 				&-type {
-					width: 45%;
 					display: inline-block;
 					margin-right: 8px;
 

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/css/fonts/cloudinary.34cb260ad722325c597cdc3a3e7584d8.woff

@@ -75,7 +75,7 @@ const TransformationsToggle = ( props ) => {
 	return (
 		<PanelBody title={__( 'Transformations', 'cloudinary' )}>
 			<ToggleControl
-				label={__( 'Overwrite Transformations', 'cloudinary' )}
+				label={__( 'Overwrite Global Transformations', 'cloudinary' )}
 				checked={overwrite_transformations}
 				onChange={( value ) => {
 					setAttributes( {overwrite_transformations: value} );

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/css/fonts/cloudinary.7e6e75b25255a2b3b6e7ced1092c210c.eot

@@ -586,7 +586,7 @@ private function template_overwrite_insert() {
 		return '<# if( data.attachment.attributes.transformations ) { #>
 			<div class="setting cld-overwrite">
 				<label>
-					<span>' . esc_html__( 'Overwrite Transformations', 'cloudinary' ) . '</span>
+					<span>' . esc_html__( 'Overwrite Global Transformations', 'cloudinary' ) . '</span>
 					<input type="checkbox" data-setting="cldoverwrite" value="true"<# if ( data.model.cldoverwrite ) { #> checked="checked"<# } #> />
 				</label>
 			</div>
@@ -602,7 +602,7 @@ private function template_overwrite_insert_video() {
 		return '<# if( \'video\' === data.type && data.attachment.attributes.transformations ) { #>
 			<div class="setting cld-overwrite">
 				<label>
-					<span>' . esc_html__( 'Overwrite Transformations', 'cloudinary' ) . '</span>
+					<span>' . esc_html__( 'Overwrite Global Transformations', 'cloudinary' ) . '</span>
 					<input type="checkbox" data-setting="cldoverwrite" value="true"<# if ( data.model.cldoverwrite ) { #> checked="checked"<# } #> />
 				</label>
 			</div>
@@ -620,7 +620,7 @@ private function template_overwrite_edit() {
 				<label>
 					<span>&nbsp;</span>
 					<input type="checkbox" data-setting="cldoverwrite" value="true" <# if ( data.model.cldoverwrite ) { #>checked="checked"<# } #> />
-					' . esc_html__( 'Overwrite Transformations', 'cloudinary' ) . '
+					' . esc_html__( 'Overwrite Global Transformations', 'cloudinary' ) . '
 				</label>
 			</div>
 		<# } #>';
@@ -636,7 +636,7 @@ private function template_overwrite_video_edit() {
 			<div class="setting cld-overwrite">
 				<label>
 					<input type="checkbox" data-setting="cldoverwrite" value="true" <# if ( data.model.cldoverwrite ) { #>checked="checked"<# } #> />
-					' . esc_html__( 'Overwrite Transformations', 'cloudinary' ) . '
+					' . esc_html__( 'Overwrite Global Transformations', 'cloudinary' ) . '
 				</label>
 			</div>
 		<# } #>';

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/css/fonts/cloudinary.c2afda9d25532c03cd41beb20a1ce439.ttf

@@ -402,11 +402,14 @@ private function init_taxonomy_manager( $post ) {
 			}
 		}
 		$out[] = '</ul>';
+		
 		// Get apply Type.
-		$type  = get_post_meta( $post->ID, self::META_APPLY_KEY . '_terms', true );
-		$out[] = '<label class="cld-tax-order-list-type"><input ' . checked( 'overwrite', $type, false ) . ' type="checkbox" value="overwrite" name="cld_apply_type" />' . __( 'Overwrite', 'cloudinary' ) . '</label>';
+		if ( ! empty( $terms ) ) {
+			$type  = get_post_meta( $post->ID, self::META_APPLY_KEY . '_terms', true );
+			$out[] = '<label class="cld-tax-order-list-type"><input ' . checked( 'overwrite', $type, false ) . ' type="checkbox" value="overwrite" name="cld_apply_type" />' . __( 'Overwrite taxonomy', 'cloudinary' ) . '</label>';
+		}
+		
 		$out[] = '</div>';
-
 		return implode( $out );
 	}
 
@@ -501,7 +504,7 @@ public function classic_overwrite_transformations_featured_image( $content, $pos
 				'<p><label for="%1$s"><input type="hidden" name="%1$s" value="0" /><input type="checkbox" name="%1$s" id="%1$s" value="1" %2$s /> %3$s</label></p>',
 				esc_attr( self::META_FEATURED_IMAGE_KEY ),
 				checked( $field_value, 1, false ),
-				esc_html__( 'Overwrite Transformations', 'cloudinary' )
+				esc_html__( 'Overwrite Global Transformations', 'cloudinary' )
 			);
 		}