Fix or ignore existing PHP styling issues

gabriel-detassigny · gabriel-detassigny · commit 2725e5768650 · 2025-08-25T14:52:04.000+09:00
diff --git a/cloudinary.php b/cloudinary.php
@@ -39,7 +39,7 @@
 if ( version_compare( phpversion(), '5.6', '>=' ) ) {
 	require_once __DIR__ . '/instance.php';
 	register_activation_hook( __FILE__, array( 'Cloudinary\Utils', 'install' ) );
-} else {
+} else { // phpcs:ignore Universal.ControlStructures.DisallowLonelyIf.Found
 	if ( defined( 'WP_CLI' ) ) {
 		WP_CLI::warning( php_version_text() );
 	} else {
diff --git a/php/class-admin.php b/php/class-admin.php
@@ -203,7 +203,7 @@ public function register_admin( $page ) {
 		$page_handle = add_menu_page(
 			$page['page_title'],
 			$page['menu_title'],
-			$page['capability'],
+			$page['capability'], // phpcs:ignore WordPress.WP.Capabilities.Undetermined
 			$page['slug'],
 			'',
 			$page['icon'],
@@ -245,7 +245,7 @@ public function register_admin( $page ) {
 				$page['slug'],
 				$page_title,
 				$menu_title,
-				$capability,
+				$capability, // phpcs:ignore WordPress.WP.Capabilities.Undetermined
 				$render_slug,
 				$render_function,
 				$position
diff --git a/php/class-assets.php b/php/class-assets.php
@@ -1365,7 +1365,7 @@ public function is_asset( $url ) {
 		global $wpdb;
 
 		// Bail early if it's not an URL.
-		if ( empty( parse_url( $url, PHP_URL_HOST ) ) ) {
+		if ( empty( parse_url( $url, PHP_URL_HOST ) ) ) { // phpcs:ignore WordPress.WP.AlternativeFunctions.parse_url_parse_url
 			return false;
 		}
 
diff --git a/php/class-media-library.php b/php/class-media-library.php
@@ -41,7 +41,7 @@ public function setup() {
 		$this->handle = add_menu_page(
 			__( 'Cloudinary Media Library', 'cloudinary' ),
 			__( 'Cloudinary DAM', 'cloudinary' ),
-			Utils::user_can( 'manage_dam' ) ? 'exist' : false,
+			Utils::user_can( 'manage_dam' ) ? 'exist' : false, // phpcs:ignore WordPress.WP.Capabilities.Undetermined
 			self::MEDIA_LIBRARY_SLUG,
 			array( $this, 'render' ),
 			'dashicons-cloudinary-dam',
diff --git a/php/class-media.php b/php/class-media.php
@@ -1305,7 +1305,7 @@ public function apply_default_transformations( array $transformations, $attachme
 	 *
 	 * @return array
 	 */
-	public function default_image_transformations( $default ) {
+	public function default_image_transformations( $default ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 
 		$config = $this->settings->get_value( 'image_settings' );
 
@@ -1330,7 +1330,7 @@ public function default_image_transformations( $default ) {
 	 *
 	 * @return array
 	 */
-	public function default_image_freeform_transformations( $default ) {
+	public function default_image_freeform_transformations( $default ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 		$config = $this->settings->get_value( 'image_settings' );
 		if ( ! empty( $config['image_freeform'] ) ) {
 			$default[] = trim( $config['image_freeform'] );
@@ -2559,7 +2559,7 @@ public function get_transformation_from_meta( $post_id ) {
 	 *
 	 * @return mixed
 	 */
-	public function get_post_meta( $post_id, $key = '', $single = false, $default = null ) {
+	public function get_post_meta( $post_id, $key = '', $single = false, $default = null ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 
 		$meta = get_post_meta( $post_id, Sync::META_KEYS['cloudinary'], true );
 		if ( empty( $meta ) ) {
diff --git a/php/class-plugin.php b/php/class-plugin.php
@@ -598,7 +598,7 @@ protected function setup_endpoints() {
 	 *
 	 * @return void
 	 */
-	public function autoload( $class ) {
+	public function autoload( $class ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.classFound
 		// Assume we're using namespaces (because that's how the plugin is structured).
 		$namespace = explode( '\\', $class );
 		$root      = array_shift( $namespace );
@@ -744,7 +744,7 @@ public function print_script_data() {
 	 *
 	 * @return array
 	 */
-	public function force_visit_plugin_site_link( $plugin_meta, $plugin_file, $plugin_data, $status ) {
+	public function force_visit_plugin_site_link( $plugin_meta, $plugin_file, $plugin_data, $status ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed
 		if ( 'Cloudinary' === $plugin_data['Name'] ) {
 			$plugin_site_link = sprintf(
 				'<a href="%s">%s</a>',
diff --git a/php/class-rest-api.php b/php/class-rest-api.php
@@ -26,7 +26,7 @@ class REST_API {
 	 *
 	 * @param Plugin $plugin Instance of the global Plugin.
 	 */
-	public function __construct( Plugin $plugin ) {
+	public function __construct( Plugin $plugin ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
 		add_action( 'rest_api_init', array( $this, 'rest_api_init' ), PHP_INT_MAX );
 	}
 
diff --git a/php/class-settings.php b/php/class-settings.php
@@ -241,7 +241,7 @@ public function get_storage_key( $slug, $type = null ) {
 	 *
 	 * @return Setting|\WP_Error
 	 */
-	public function add( $slug, $default = array(), $params = array() ) {
+	public function add( $slug, $default = array(), $params = array() ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 		$default_params = array(
 			'type'                     => 'tag',
 			self::META_KEYS['storage'] => $slug,
@@ -294,7 +294,7 @@ public function add( $slug, $default = array(), $params = array() ) {
 	 *
 	 * @return mixed|Setting
 	 */
-	protected function register( $slug, $default, $params ) {
+	protected function register( $slug, $default, $params ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 
 		if ( isset( $this->settings[ $slug ] ) ) {
 			return $this->settings[ $slug ];
diff --git a/php/class-string-replace.php b/php/class-string-replace.php
@@ -195,7 +195,7 @@ public function init_debug( $template ) {
 	 *
 	 * @return bool
 	 */
-	public static function string_set( $string ) {
+	public static function string_set( $string ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound
 		return isset( self::$replacements[ $string ] );
 	}
 
@@ -206,7 +206,7 @@ public static function string_set( $string ) {
 	 *
 	 * @return bool
 	 */
-	public static function string_not_set( $string ) {
+	public static function string_not_set( $string ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound
 		return ! self::string_set( $string );
 	}
 
diff --git a/php/class-sync.php b/php/class-sync.php
@@ -1105,7 +1105,7 @@ public function maybe_cleanup_errored() {
 
 		delete_post_meta_by_key( self::META_KEYS['sync_error'] );
 
-		wp_redirect(
+		wp_redirect( // phpcs:ignore WordPress.Security.SafeRedirect.wp_redirect_wp_redirect
 			add_query_arg(
 				array(
 					'page'   => 'cloudinary',
diff --git a/php/class-utils.php b/php/class-utils.php
@@ -258,7 +258,7 @@ public static function user_can( $task, $capability = 'manage_options', $context
 		$capability = apply_filters( 'cloudinary_task_capability', $capability, $task, $context, ...$args );
 		// phpcs:enable WordPress.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
 
-		return current_user_can( $capability, ...$args );
+		return current_user_can( $capability, ...$args ); // phpcs:ignore WordPress.WP.Capabilities.Undetermined
 	}
 
 	/**
@@ -758,7 +758,7 @@ public static function purge_fragments() {
 	public static function purge_fragment( $index ) {
 		if ( isset( self::$file_fragments[ $index ] ) ) {
 			fclose( self::$file_fragments[ $index ]['pointer'] ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_read_fclose
-			unlink( self::$file_fragments[ $index ]['file'] );
+			unlink( self::$file_fragments[ $index ]['file'] ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_unlink
 		}
 	}
 
diff --git a/php/connect/class-api.php b/php/connect/class-api.php
@@ -186,7 +186,7 @@ public function setup( Plugin $plugin ) {
 	 *
 	 * @return string
 	 */
-	public function url( $resource, $function = null, $endpoint = false ) {
+	public function url( $resource, $function = null, $endpoint = false ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames
 		$parts = array();
 
 		if ( $endpoint ) {
diff --git a/php/media/class-filter.php b/php/media/class-filter.php
@@ -778,7 +778,7 @@ public function record_meta_update( $data, $id ) {
 	 *
 	 * @return bool
 	 */
-	public function edit_match_src( $match, $image_location, $image_meta, $attachment_id ) {
+	public function edit_match_src( $match, $image_location, $image_meta, $attachment_id ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.matchFound
 		if ( $this->media->is_cloudinary_url( $image_location ) ) {
 			$test_id   = $this->media->get_public_id_from_url( $image_location );
 			$public_id = $this->media->get_public_id( $attachment_id );
diff --git a/php/media/class-gallery.php b/php/media/class-gallery.php
@@ -707,7 +707,7 @@ public function setup_hooks() {
 		 * @return bool
 		 */
 		if ( apply_filters( 'cloudinary_allow_glb_upload', false ) ) {
-			add_filter( 'upload_mimes', array( $this, 'add_glb_mime' ), 20, 1 );
+			add_filter( 'upload_mimes', array( $this, 'add_glb_mime' ), 20, 1 ); // phpcs:ignore WordPressVIPMinimum.Hooks.RestrictedHooks.upload_mimes
 			add_filter( 'wp_check_filetype_and_ext', array( $this, 'pass_glb_filetype_check' ), 10, 3 );
 			add_filter( 'cloudinary_allowed_extensions', array( $this, 'allow_glb_for_cloudinary' ) );
 			add_filter( 'cloudinary_is_deliverable', array( $this, 'allow_glb_delivery_from_cloudinary' ), 10, 2 );
diff --git a/php/media/class-video.php b/php/media/class-video.php
@@ -532,7 +532,7 @@ protected function build_video_embed( $source, $attributes = array(), $overwrite
 	 *
 	 * @return array
 	 */
-	public function default_video_transformations( $default ) {
+	public function default_video_transformations( $default ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 
 		if ( 'on' === $this->config['video_optimization'] ) {
 			if ( 'auto' === $this->config['video_format'] ) {
@@ -555,7 +555,7 @@ public function default_video_transformations( $default ) {
 	 *
 	 * @return array
 	 */
-	public function default_video_freeform_transformations( $default ) {
+	public function default_video_freeform_transformations( $default ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 		if ( ! empty( $this->config['video_freeform'] ) ) {
 			$default[] = trim( $this->config['video_freeform'] );
 		}
@@ -664,7 +664,7 @@ function ( $atts ) {
 				 *
 				 * @return string
 				 */
-				static function ( $return, $tag, $attr, $m ) {
+				static function ( $return, $tag, $attr, $m ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.returnFound
 					global $shortcode_tags;
 					if ( 'video' === $tag ) {
 						$supported_formats = array_merge(
diff --git a/php/relate/class-relationship.php b/php/relate/class-relationship.php
@@ -213,7 +213,7 @@ public static function set_cache( $post_id, $media_context, $data ) {
 	public function delete() {
 		global $wpdb;
 		$table_name = Utils::get_relationship_table();
-		$wpdb->delete(
+		$wpdb->delete( // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
 			$table_name,
 			array(
 				'post_id'       => $this->post_id,
diff --git a/php/settings/class-setting.php b/php/settings/class-setting.php
@@ -85,7 +85,7 @@ public function __construct( $slug, $root = null, $params = array() ) {
 	 *
 	 * @param string $parent The slug of the parent setting.
 	 */
-	public function set_parent( $parent ) {
+	public function set_parent( $parent ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.parentFound
 		$this->parent = $parent;
 	}
 
diff --git a/php/sync/class-download-sync.php b/php/sync/class-download-sync.php
@@ -84,7 +84,7 @@ public function rest_endpoints( $endpoints ) {
 	 *
 	 * @return bool
 	 */
-	public function rest_can_upload_files( \WP_REST_Request $request ) {
+	public function rest_can_upload_files( \WP_REST_Request $request ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
 
 		// This would have been from an ajax call. Therefore verify based on capability.
 		return Utils::user_can( 'manage_assets', 'upload_files', 'download' );
diff --git a/php/traits/trait-cli.php b/php/traits/trait-cli.php
@@ -501,7 +501,7 @@ protected function maybe_do_export( $unsynced_attachments, $errored_attachments
 	protected function export_csv( $data, $type ) {
 		$upload   = wp_get_upload_dir();
 		$filename = trailingslashit( $upload['path'] ) . sanitize_file_name( 'cloudinary-' . $type . '-' . time() . '.csv' );
-		$fp       = fopen( $filename, 'wb+' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_read_fopen
+		$fp       = fopen( $filename, 'wb+' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_read_fopen,WordPress.WP.AlternativeFunctions.file_system_operations_fopen
 
 		foreach ( $data as $fields ) {
 			fputcsv( $fp, $fields ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_fputcsv
diff --git a/php/traits/trait-params.php b/php/traits/trait-params.php
@@ -213,7 +213,7 @@ public function has_params() {
 	 *
 	 * @return mixed|self
 	 */
-	public function get_param( $param, $default = null ) {
+	public function get_param( $param, $default = null ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 		$param = $this->sanitize_slug( $param );
 
 		$value = $this->get_array_param( $param );
diff --git a/php/ui/class-component.php b/php/ui/class-component.php
@@ -327,7 +327,7 @@ protected function is_enabled() {
 	 *
 	 * @return string
 	 */
-	public function render( $echo = false ) {
+	public function render( $echo = false ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
 		// Setup the component.
 		$this->pre_render();
 
diff --git a/php/ui/class-state.php b/php/ui/class-state.php
@@ -61,7 +61,7 @@ class State {
 	 *
 	 * @param Plugin $plugin Instance of the plugin.
 	 */
-	public function __construct( Plugin $plugin ) {
+	public function __construct( Plugin $plugin ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
 		$this->plugin  = get_plugin_instance();
 		$this->user_id = get_current_user_id();
 
@@ -158,7 +158,7 @@ public function set_state( \WP_REST_Request $request ) {
 	 *
 	 * @return mixed
 	 */
-	public function get_state( $key, $default = null ) {
+	public function get_state( $key, $default = null ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 
 		// Add default if not set yet.
 		if ( empty( $this->state[ $key ] ) ) {
diff --git a/php/ui/component/class-asset.php b/php/ui/component/class-asset.php
@@ -11,8 +11,8 @@
 use Cloudinary\Assets;
 use Cloudinary\UI\Component;
 use Cloudinary\Utils;
-use function Cloudinary\get_plugin_instance;
 use Cloudinary\Settings\Setting;
+use function Cloudinary\get_plugin_instance;
 
 /**
  * HTML Component to render components only.
diff --git a/php/ui/component/class-color.php b/php/ui/component/class-color.php
@@ -50,7 +50,7 @@ protected function input( $struct ) {
 	 *
 	 * @return string|null
 	 */
-	public function render( $echo = false ) {
+	public function render( $echo = false ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
 		$return = parent::render( $echo );
 		?>
 		<script>
diff --git a/php/ui/component/class-connect.php b/php/ui/component/class-connect.php
@@ -7,9 +7,9 @@
 
 namespace Cloudinary\UI\Component;
 
-use function Cloudinary\get_plugin_instance;
 use Cloudinary\UI\Component;
 use Cloudinary\Settings\Setting;
+use function Cloudinary\get_plugin_instance;
 
 /**
  * Connect Component.
diff --git a/php/ui/component/class-media-status.php b/php/ui/component/class-media-status.php
@@ -7,13 +7,13 @@
 
 namespace Cloudinary\UI\Component;
 
-use function Cloudinary\get_plugin_instance;
 use Cloudinary\UI\Component;
 use Cloudinary\Settings\Setting;
 use Cloudinary\Sync;
 use Cloudinary\Media;
 use Cloudinary\Cache;
 use Cloudinary\Plugin;
+use function Cloudinary\get_plugin_instance;
 
 /**
  * Media Sync Status Component to render plan status.
diff --git a/php/ui/component/class-notice.php b/php/ui/component/class-notice.php
@@ -109,7 +109,7 @@ protected function dismiss( $struct ) {
 	 *
 	 * @return string
 	 */
-	public function render( $echo = false ) {
+	public function render( $echo = false ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
 		// Render component via parent.
 		$return = parent::render();
 		$this->setting->set_param( 'rendered', true );
diff --git a/php/ui/component/class-plan-status.php b/php/ui/component/class-plan-status.php
@@ -7,10 +7,10 @@
 
 namespace Cloudinary\UI\Component;
 
-use function Cloudinary\get_plugin_instance;
 use Cloudinary\UI\Component;
 use Cloudinary\Settings\Setting;
 use Cloudinary\Connect;
+use function Cloudinary\get_plugin_instance;
 
 /**
  * Plan Status Component to render plan status.
diff --git a/php/ui/component/class-plan.php b/php/ui/component/class-plan.php
@@ -7,10 +7,10 @@
 
 namespace Cloudinary\UI\Component;
 
-use function Cloudinary\get_plugin_instance;
 use Cloudinary\UI\Component;
 use Cloudinary\Settings\Setting;
 use Cloudinary\Connect;
+use function Cloudinary\get_plugin_instance;
 
 /**
  * Plan Component to render plan status.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -34,7 +34,9 @@
 	</rule>
 
 	<!-- Include WP VIP coding standard checks -->
-	<rule ref="WordPress-VIP-Go" />
+	<rule ref="WordPress-VIP-Go">
+        <exclude name="WordPressVIPMinimum.Functions.RestrictedFunctions.wp_remote_get_wp_remote_get" />
+	</rule>
 
 	<exclude-pattern>/build/</exclude-pattern>
 	<exclude-pattern>/js/</exclude-pattern>
diff --git a/ui-definitions/settings-pages.php b/ui-definitions/settings-pages.php
@@ -283,8 +283,8 @@
 					),
 				),
 				array(
-					'type'                => 'column',
-					'attributes'          => array(
+					'type'       => 'column',
+					'attributes' => array(
 						'wrap' => array(
 							'class' => array(
 								'help-box',

Original file line number	Diff line number	Diff line change
`@@ -1365,7 +1365,7 @@ public function is_asset( $url ) {`
`1365`	`1365`	`global $wpdb;`
`1366`	`1366`
`1367`	`1367`	`// Bail early if it's not an URL.`
`1368`		`- if ( empty( parse_url( $url, PHP_URL_HOST ) ) ) {`
	`1368`	`+ if ( empty( parse_url( $url, PHP_URL_HOST ) ) ) { // phpcs:ignore WordPress.WP.AlternativeFunctions.parse_url_parse_url`
`1369`	`1369`	`return false;`
`1370`	`1370`	`}`
`1371`	`1371`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class REST_API {`
`26`	`26`	`*`
`27`	`27`	`* @param Plugin $plugin Instance of the global Plugin.`
`28`	`28`	`*/`
`29`		`- public function __construct( Plugin $plugin ) {`
	`29`	`+ public function __construct( Plugin $plugin ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found`
`30`	`30`	`add_action( 'rest_api_init', array( $this, 'rest_api_init' ), PHP_INT_MAX );`
`31`	`31`	`}`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ public function init_debug( $template ) {`
`195`	`195`	`*`
`196`	`196`	`* @return bool`
`197`	`197`	`*/`
`198`		`- public static function string_set( $string ) {`
	`198`	`+ public static function string_set( $string ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound`
`199`	`199`	`return isset( self::$replacements[ $string ] );`
`200`	`200`	`}`
`201`	`201`
`@@ -206,7 +206,7 @@ public static function string_set( $string ) {`
`206`	`206`	`*`
`207`	`207`	`* @return bool`
`208`	`208`	`*/`
`209`		`- public static function string_not_set( $string ) {`
	`209`	`+ public static function string_not_set( $string ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound`
`210`	`210`	`return ! self::string_set( $string );`
`211`	`211`	`}`
`212`	`212`