Fix the cache logic to get attachment ID from URl

Author: Marco Pereirinha

php/class-utils.php

@@ -923,14 +923,17 @@ public static function get_registered_sizes( $attachment_id = null ) {
 	 * @return int
 	 */
 	public static function attachment_url_to_postid( $url ) {
-		$attachment_id = 0;
+		$key = "postid_{$url}";
+
 		if ( function_exists( 'wpcom_vip_attachment_url_to_postid' ) ) {
 			$attachment_id = wpcom_vip_attachment_url_to_postid( $url );
+		} else {
+			$attachment_id = wp_cache_get( $key, 'cloudinary' );
 		}
 
-		if ( 0 === $attachment_id && empty( wp_cache_get( "postid_{$url}", 'cloudinary' ) ) ) {
+		if ( empty( $attachment_id ) ) {
 			$attachment_id = attachment_url_to_postid( $url ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.attachment_url_to_postid_attachment_url_to_postid
-			wp_cache_set( "postid_{$url}", $attachment_id, 'cloudinary' );
+			wp_cache_set( $key, $attachment_id, 'cloudinary' );
 		}
 
 		return $attachment_id;