set values on or off only

Author: DavidCramer

php/class-media.php

@@ -773,7 +773,7 @@ public function default_image_transformations( $default ) {
 
 		$config = $this->settings->get_value( 'image_settings' );
 
-		if ( true === $config['image_optimization'] ) {
+		if ( 'on' === $config['image_optimization'] ) {
 			if ( 'auto' === $config['image_format'] ) {
 				$default['fetch_format'] = 'auto';
 			}

php/ui/component/class-on-off.php

@@ -33,7 +33,7 @@ protected function false_value( $struct ) {
 		$struct['element']             = 'input';
 		$struct['attributes']['type']  = 'hidden';
 		$struct['attributes']['name']  = $this->get_name();
-		$struct['attributes']['value'] = false;
+		$struct['attributes']['value'] = 'off';
 		unset( $struct['attributes']['class'] );
 		unset( $struct['attributes']['data-bound'] );
 		$struct['render'] = true;
@@ -54,8 +54,8 @@ protected function input( $struct ) {
 		$struct['attributes']['type']  = 'checkbox';
 		$struct['attributes']['name']  = $this->get_name();
 		$struct['attributes']['id']    = $this->setting->get_slug();
-		$struct['attributes']['value'] = true;
-		if ( $this->setting->get_value() ) {
+		$struct['attributes']['value'] = 'on';
+		if ( 'true' === $this->setting->get_value() ) {
 			$struct['attributes']['checked'] = 'checked';
 		}
 		$struct['attributes']['class'] = 'cld-ui-input';
@@ -106,6 +106,6 @@ protected function slider( $struct ) {
 	 * @return bool
 	 */
 	public function sanitize_value( $value ) {
-		return (bool) $value;
+		return 'on' === $value ? 'on' : 'off';
 	}
 }

ui-definitions/settings-image.php

@@ -25,12 +25,11 @@
 						'title'        => __( 'Image optimization', 'cloudinary' ),
 						'tooltip_text' => __( 'Images will be delivered using Cloudinary’s automatic format and quality algorithms for the best tradeoff between visual quality and file size. Use Advanced Optimization options to manually tune format and quality.', 'cloudinary' ),
 						'description'  => __( 'Optimize images on my site.', 'cloudinary' ),
-						'default'      => true,
+						'default'      => 'on',
 						'attributes'   => array(
 							'data-context' => 'image',
 						),
 					),
-
 				),
 				array(
 					'type'        => 'group',

ui-definitions/settings-video.php

@@ -46,7 +46,7 @@
 							'slug'        => 'video_loop',
 							'description' => __( ' Repeat video', 'cloudinary' ),
 							'type'        => 'on_off',
-							'default'     => false,
+							'default'     => 'off',
 						),
 						array(
 							'slug'        => 'video_autoplay_mode',
@@ -72,7 +72,7 @@
 						'title'        => __( 'Bitrate', 'cloudinary' ),
 						'description'  => __( 'Enable bitrate limiter', 'cloudinary' ),
 						'tooltip_text' => __( 'If set, all videos will be delivered in the defined bitrate.', 'cloudinary' ),
-						'default'      => false,
+						'default'      => 'off',
 						'attributes'   => array(
 							'data-context' => 'video',
 						),
@@ -102,7 +102,7 @@
 						'title'        => __( 'Video optimization', 'cloudinary' ),
 						'tooltip_text' => __( 'Videos will be delivered using Cloudinary’s automatic format and quality algorithms for the best tradeoff between visual quality and file size. Use Advanced Optimization options to manually tune format and quality.', 'cloudinary' ),
 						'description'  => __( 'Optimize videos on my site.', 'cloudinary' ),
-						'default'      => true,
+						'default'      => 'on',
 						'attributes'   => array(
 							'data-context' => 'video',
 						),