ensure correct value - defaults

Author: DavidCramer

php/class-media.php

@@ -1145,7 +1145,7 @@ public function image_srcset( $sources, $size_array, $image_src, $image_meta, $a
 
 		$image_meta['overwrite_transformations'] = ! empty( $image_meta['overwrite_transformations'] ) ? $image_meta['overwrite_transformations'] : false;
 
-		if ( $this->settings->get_setting( 'enable_breakpoints' )->get_value() && wp_image_matches_ratio( $image_meta['width'], $image_meta['height'], $size_array[0], $size_array[1] ) ) {
+		if ( 'on' === $this->settings->get_setting( 'enable_breakpoints' )->get_value() && wp_image_matches_ratio( $image_meta['width'], $image_meta['height'], $size_array[0], $size_array[1] ) ) {
 			$meta = $this->get_post_meta( $attachment_id, Sync::META_KEYS['breakpoints'], true );
 			if ( ! empty( $meta ) ) {
 				// Since srcset is primary and src is a fallback, we need to set the first srcset with the main image.
@@ -1718,7 +1718,7 @@ public function get_breakpoint_options( $attachment_id ) {
 		$breakpoints = array();
 		$settings    = $this->settings->get_setting( self::MEDIA_SETTINGS_SLUG )->get_value();
 
-		if ( ! empty( $settings['enable_breakpoints'] ) && wp_attachment_is_image( $attachment_id ) ) {
+		if ( 'on' === $settings['enable_breakpoints'] && wp_attachment_is_image( $attachment_id ) ) {
 			$meta = wp_get_attachment_metadata( $attachment_id );
 			// Get meta image size if non exists.
 			if ( empty( $meta ) ) {

php/media/class-video.php

@@ -442,10 +442,10 @@ public function filter_video_block_pre_render( $block, $source_block ) {
 	 */
 	public function default_video_transformations( $default ) {
 
-		if ( ! empty( $this->config['video_limit_bitrate'] ) ) {
+		if ( 'on' === $this->config['video_limit_bitrate'] ) {
 			$default['bit_rate'] = $this->config['video_bitrate'] . 'k';
 		}
-		if ( ! empty( $this->config['video_optimization'] ) && true === $this->config['video_optimization'] ) {
+		if ( 'on' === $this->config['video_optimization'] ) {
 			if ( 'auto' === $this->config['video_format'] ) {
 				$default['fetch_format'] = 'auto';
 			}

php/sync/class-upload-sync.php

@@ -330,7 +330,7 @@ public function explicit_update( $attachment_id ) {
 	 */
 	public function update_breakpoints( $attachment_id, $breakpoints ) {
 
-		if ( ! empty( $this->plugin->settings->get_value( 'enable_breakpoints' ) ) ) {
+		if ( 'on' === $this->plugin->settings->get_value( 'enable_breakpoints' ) ) {
 			if ( ! empty( $breakpoints['responsive_breakpoints'] ) ) { // Images only.
 				$this->media->update_post_meta( $attachment_id, Sync::META_KEYS['breakpoints'], $breakpoints['responsive_breakpoints'][0]['breakpoints'] );
 			} elseif ( wp_attachment_is_image( $attachment_id ) ) {

ui-definitions/settings-image.php

@@ -91,6 +91,7 @@
 						'title'        => __( 'Image breakpoints', 'cloudinary' ),
 						'tooltip_text' => __( 'Automatically generate multiple sizes based on the configured breakpoints to enable your images to responsively adjust to different screen sizes. Note that your Cloudinary usage will increase when enabling responsive images.', 'cloudinary' ),
 						'description'  => __( 'Enable responsive images.', 'cloudinary' ),
+						'default'      => 'off',
 					),
 					array(
 						'type'      => 'group',

ui-definitions/settings-video.php

@@ -85,7 +85,7 @@
 						'default'     => '500',
 						'suffix'      => 'k',
 						'condition'   => array(
-							'video_limit_bitrate' => true,
+							'video_limit_bitrate' => 'on',
 						),
 						'attributes'  => array(
 							'data-context' => 'video',
@@ -113,7 +113,7 @@
 					'title'       => __( 'Advanced optimization', 'cloudinary' ),
 					'collapsible' => 'open',
 					'condition'   => array(
-						'video_optimization' => true,
+						'video_optimization' => 'on',
 					),
 					array(
 						'type'         => 'select',