Merge pull request #1013 from cloudinary/fix/util-deprecation-notice-php83

tharsheblows · web-flow · commit 7e365fd2e257 · 2025-01-30T08:05:05.000-05:00
Fix: Deprecation notices in `Utils::is_rest_api`
diff --git a/php/class-utils.php b/php/class-utils.php
@@ -574,7 +574,7 @@ public static function is_rest_api() {
 			// Fallback if rest engine is not setup yet.
 			$rest_base   = wp_parse_url( static::rest_url( '/' ), PHP_URL_PATH );
 			$request_uri = filter_input( INPUT_SERVER, 'REQUEST_URI', FILTER_SANITIZE_URL );
-			$is          = strpos( $request_uri, $rest_base ) === 0;
+			$is          = is_string( $request_uri ) && strpos( $request_uri, $rest_base ) === 0;
 		}
 
 		return $is;

Original file line number	Diff line number	Diff line change
`@@ -574,7 +574,7 @@ public static function is_rest_api() {`
`574`	`574`	`// Fallback if rest engine is not setup yet.`
`575`	`575`	`$rest_base = wp_parse_url( static::rest_url( '/' ), PHP_URL_PATH );`
`576`	`576`	`$request_uri = filter_input( INPUT_SERVER, 'REQUEST_URI', FILTER_SANITIZE_URL );`
`577`		`- $is = strpos( $request_uri, $rest_base ) === 0;`
	`577`	`+ $is = is_string( $request_uri ) && strpos( $request_uri, $rest_base ) === 0;`
`578`	`578`	`}`
`579`	`579`
`580`	`580`	`return $is;`