Merge pull request #356 from cloudinary/fix/push-sync

use add_setting_error since it's been connected to the internal notices

Author: pereirinha

php/settings/class-setting.php

@@ -466,7 +466,7 @@ public function prepare_sanitizer( $data ) {
 			 *
 			 * @param mixed   $new_value     The new setting value.
 			 * @param mixed   $current_value The setting current value.
-			 * @param Setting $value         The setting object.
+			 * @param Setting $setting         The setting object.
 			 */
 			$new_value = apply_filters( "cloudinary_settings_save_setting_{$slug}", $new_value, $current_value, $setting );
 			$new_value = apply_filters( 'cloudinary_settings_save_setting', $new_value, $current_value, $setting );

php/sync/class-sync-queue.php

@@ -192,7 +192,7 @@ public function change_setting_state( $new_value, $current_value, $setting ) {
 		if ( 'on' === $current_value && 'off' === $new_value ) {
 			if ( $this->is_running() ) {
 				$this->shutdown_queue( 'queue' );
-				$setting->add_error_notice( 'disabled_sync', 'Bulk sync has been disabled.', 'warning' );
+				add_settings_error( $setting->get_option_name(), 'disabled_sync', __( 'Bulk sync has been disabled.', 'cloudinary' ), 'warning' );
 			}
 			// Shutdown autosync queue.
 			$this->shutdown_queue( 'autosync' );