Syncing flag should only be set if auto sync is enabled

Marco Pereirinha · Marco Pereirinha · commit b7a7ac608bf4 · 2020-07-22T14:33:57.000+01:00
diff --git a/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php b/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php
@@ -109,7 +109,7 @@ public function is_synced( $post_id ) {
 			return true;
 		}
 
-		if ( apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {
+		if ( $this->plugin->components['settings']->is_auto_sync_enabled() && apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {
 			update_post_meta( $post_id, Sync::META_KEYS['syncing'], true );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function is_synced( $post_id ) {`
`109`	`109`	`return true;`
`110`	`110`	`}`
`111`	`111`
`112`		`- if ( apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {`
	`112`	`+ if ( $this->plugin->components['settings']->is_auto_sync_enabled() && apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {`
`113`	`113`	`update_post_meta( $post_id, Sync::META_KEYS['syncing'], true );`
`114`	`114`	`}`
`115`	`115`