Merge pull request #905 from cloudinary/feature/seo-urls

pereirinha · web-flow · commit c494216fd316 · 2023-10-04T16:52:42.000+01:00
Add support for `$attachment_id` on `cloudinary_seo_public_id` filter
diff --git a/php/connect/class-api.php b/php/connect/class-api.php
@@ -851,10 +851,11 @@ public function get_public_id( $attachment_id, $original_public_id = null, $args
 			 *
 			 * @param $public_id          {string} The suffixed public_id.
 			 * @param $original_public_id {string} The original public_id.
+			 * @param $attachment_id      {int}    The attachment ID.
 			 *
 			 * @return {string}
 			 */
-			$public_id = apply_filters( 'cloudinary_seo_public_id', "{$public_id}/{$filename}.{$relationship->format}", $original_public_id );
+			$public_id = apply_filters( 'cloudinary_seo_public_id', "{$public_id}/{$filename}.{$relationship->format}", $original_public_id, $attachment_id );
 		}
 
 		return $public_id;

Original file line number	Diff line number	Diff line change
`@@ -851,10 +851,11 @@ public function get_public_id( $attachment_id, $original_public_id = null, $args`
`851`	`851`	`*`
`852`	`852`	`* @param $public_id {string} The suffixed public_id.`
`853`	`853`	`* @param $original_public_id {string} The original public_id.`
	`854`	`+ * @param $attachment_id {int} The attachment ID.`
`854`	`855`	`*`
`855`	`856`	`* @return {string}`
`856`	`857`	`*/`
`857`		`- $public_id = apply_filters( 'cloudinary_seo_public_id', "{$public_id}/{$filename}.{$relationship->format}", $original_public_id );`
	`858`	`+ $public_id = apply_filters( 'cloudinary_seo_public_id', "{$public_id}/{$filename}.{$relationship->format}", $original_public_id, $attachment_id );`
`858`	`859`	`}`
`859`	`860`
`860`	`861`	`return $public_id;`