Merge pull request #862 from cloudinary/improvements/vip-feedback

Improvements vip feedback

Author: pereirinha

php/cache/class-cache-point.php

@@ -198,13 +198,14 @@ public function delete_meta( $check, $object_id, $meta_key, $meta_value ) {
 	public function get_meta( $check, $object_id, $meta_key ) {
 
 		if ( self::POST_TYPE_SLUG === get_post_type( $object_id ) ) {
-			$meta = $this->get_meta_cache( $object_id );
+			$meta  = $this->get_meta_cache( $object_id );
+			$value = '';
+
 			if ( empty( $meta_key ) ) {
 				$value = $meta;
 			} elseif ( isset( $meta[ $meta_key ] ) ) {
+				$value   = array();
 				$value[] = $meta[ $meta_key ];
-			} else {
-				$value = '';
 			}
 
 			return $value;
@@ -431,11 +432,12 @@ protected function load_cache_point( $url ) {
 			$url         = trailingslashit( $url );
 			$cache_point = null;
 			$params      = array(
-				'name'           => $key,
-				'post_type'      => self::POST_TYPE_SLUG,
-				'posts_per_page' => 1,
+				'name'             => $key,
+				'post_type'        => self::POST_TYPE_SLUG,
+				'posts_per_page'   => 1,
+				'suppress_filters' => false,
 			);
-			$found       = get_posts( $params );
+			$found       = get_posts( $params ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.get_posts_get_posts
 			if ( ! empty( $found ) ) {
 				$cache_point                           = array_shift( $found );
 				$this->registered_cache_points[ $url ] = $cache_point;

php/cache/class-file-system.php

@@ -182,7 +182,7 @@ public function get_file_src_root( $file_url ) {
 	 */
 	public function get_location( $path ) {
 		$location_path = trailingslashit( dirname( $path ) );
-		$type          = array_search( $location_path, $this->paths );
+		$type          = array_search( $location_path, $this->paths, true );
 
 		return $type ? $type : 'root';
 	}
@@ -346,7 +346,7 @@ function ( $file ) use ( $files ) {
 				$offset   = strlen( $file ) - strlen( $ext );
 				$min_file = substr( $file, 0, $offset ) . 'min.' . $ext;
 
-				return ! in_array( $min_file, $files );
+				return ! in_array( $min_file, $files, true );
 			}
 		);
 

php/class-admin.php

@@ -308,7 +308,7 @@ public function render() {
 			// If the section has a defined template, use that instead eg. wizard.
 			$file = $this->plugin->dir_path . 'ui-definitions/components/' . $template . '.php';
 		}
-		include $file;
+		include $file; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable
 	}
 
 	/**
@@ -414,7 +414,6 @@ public function init_setting_save() {
 		$saving = filter_input_array( INPUT_POST, $args, false );
 		if ( ! empty( $saving ) && ! empty( $saving[ $submission ] ) && wp_verify_nonce( $saving['_cld_nonce'], 'cloudinary-settings' ) ) {
 			$referer = $saving['_wp_http_referer'];
-			wp_parse_str( wp_parse_url( $referer, PHP_URL_QUERY ), $query );
 
 			$data = $saving[ $submission ];
 			$this->save_settings( $submission, $data );

php/class-cache.php

@@ -138,7 +138,7 @@ public function frontend_rewrite( $template ) {
 			return $template;
 		}
 		ob_start( array( $this, 'html_rewrite' ) );
-		include $template;
+		include $template; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable
 
 		return CLDN_PATH . 'php/cache/template.php';
 	}

php/class-connect.php

@@ -1056,7 +1056,7 @@ public static function test_rest_api_connectivity() {
 	 */
 	protected function get_connection_string_content() {
 		ob_start();
-		include $this->plugin->dir_path . 'php/templates/connection-string.php';
+		include $this->plugin->dir_path . 'php/templates/connection-string.php'; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable
 
 		return ob_get_clean();
 	}

php/class-delivery.php

@@ -1055,7 +1055,7 @@ protected function standardize_tag( $tag_element ) {
 			$tag_element['atts']['data-format'] = $tag_element['format'];
 		}
 		// Add wp-{media-type}-{id} class name.
-		if ( empty( $tag_element['atts']['class'] ) || ! in_array( 'wp-' . $tag_element['type'] . '-' . $tag_element['id'], $tag_element['atts']['class'] ) ) {
+		if ( empty( $tag_element['atts']['class'] ) || ! in_array( 'wp-' . $tag_element['type'] . '-' . $tag_element['id'], $tag_element['atts']['class'], true ) ) {
 			$tag_element['atts']['class'][] = 'wp-' . $tag_element['type'] . '-' . $tag_element['id'];
 		}
 
@@ -1541,11 +1541,12 @@ protected function set_usability( $item, $auto_sync = null ) {
 		 */
 		$item = apply_filters( 'cloudinary_set_usable_asset', $item );
 
+		$found                       = array();
 		$found[ $item['public_id'] ] = $item;
-		$scaled                            = self::make_scaled_url( $item['sized_url'] );
-		$descaled                          = self::descaled_url( $item['sized_url'] );
-		$scaled_slashed                    = addcslashes( $scaled, '/' );
-		$descaled_slashed                  = addcslashes( $descaled, '/' );
+		$scaled                      = self::make_scaled_url( $item['sized_url'] );
+		$descaled                    = self::descaled_url( $item['sized_url'] );
+		$scaled_slashed              = addcslashes( $scaled, '/' );
+		$descaled_slashed            = addcslashes( $descaled, '/' );
 		$found[ $scaled ]            = $item;
 		$found[ $descaled ]          = $item;
 		$found[ $scaled_slashed ]    = array_merge( $item, array( 'slashed' => true ) );