set error and remove on success

Author: DavidCramer

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-upgrade.php

@@ -59,11 +59,11 @@ public function check_cloudinary_version( $cloudinary_id, $attachment_id ) {
 				// Has public ID, but still has cloudinary, check pending status.
 				$is_pending = $this->media->get_post_meta( $attachment_id, Sync::META_KEYS['pending'], true );
 				$attempts   = (int) $this->media->get_post_meta( $attachment_id, Sync::META_KEYS['attempts'], true );
-				$expire     = time() - 5;// * 60;
-				if ( ( empty( $is_pending ) || $is_pending < $expire ) && 10 >= $attempts ) {
+				if ( ( empty( $is_pending ) || $is_pending < time() - 5 * 60 ) && 10 > $attempts ) {
 					// Timeout.
 					$this->media->update_post_meta( $attachment_id, Sync::META_KEYS['attempts'], $attempts + 1 );
 
+					// return proposed ID to allow front render.
 					return $this->convert_cloudinary_version( $attachment_id );
 				}
 				$cloudinary_id = $public_id;

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/sync/class-download-sync.php

@@ -94,7 +94,7 @@ public function handle_failed_download( $attachment_id, $error ) {
 		$is_pending = $this->plugin->components['media']->get_post_meta( $attachment_id, Sync::META_KEYS['pending'], true );
 		if ( ! empty( $is_pending ) ) {
 			// Dont delete if it's a downsync.
-			delete_post_meta( $attachment_id, Sync::META_KEYS['pending'] );
+			$this->plugin->components['media']->update_post_meta( $attachment_id, Sync::META_KEYS['sync_error'], __( 'Could not download asset', 'cloudinary' ) );
 		} else {
 			// Delete attachment temp.
 			wp_delete_attachment( $attachment_id, true );
@@ -191,6 +191,7 @@ public function rest_download_asset( \WP_REST_Request $request ) {
 
 		// Remove pending.
 		delete_post_meta( $attachment_id, Sync::META_KEYS['pending'] );
+		delete_post_meta( $attachment_id, Sync::META_KEYS['sync_error'] );
 
 		return rest_ensure_response( $response );
 	}