Skip to content

Commit f1ee369

Browse files
Merge pull request #210 from cloudinary/fix-plugins
fix: return last plugin response
2 parents b180bff + 1f725b8 commit f1ee369

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

packages/html/src/utils/render.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Plugins, HtmlPluginState, BaseAnalyticsOptions} from '../types'
1+
import {Plugins, HtmlPluginState, BaseAnalyticsOptions, PluginResponse} from '../types'
22
import {CloudinaryVideo, CloudinaryImage} from "@cloudinary/url-gen";
33

44
/**
@@ -11,13 +11,15 @@ import {CloudinaryVideo, CloudinaryImage} from "@cloudinary/url-gen";
1111
* @param analyticsOptions {BaseAnalyticsOptions} analytics options for the url to be created
1212
*/
1313
export async function render(element: HTMLImageElement | HTMLVideoElement, pluginCloudinaryAsset: CloudinaryImage | CloudinaryVideo, plugins: Plugins, pluginState: HtmlPluginState, analyticsOptions?: BaseAnalyticsOptions) {
14-
if(plugins === undefined) return;
15-
for(let i = 0; i < plugins.length; i++){
16-
const response = await plugins[i](element, pluginCloudinaryAsset, pluginState, analyticsOptions);
17-
if(response === 'canceled'){
14+
if (plugins === undefined) return;
15+
let response: PluginResponse;
16+
for (let i = 0; i < plugins.length; i++) {
17+
response = await plugins[i](element, pluginCloudinaryAsset, pluginState, analyticsOptions);
18+
if (response === 'canceled') {
1819
break;
19-
} else {
20-
return response
2120
}
2221
}
22+
if (response !== 'canceled') {
23+
return response;
24+
}
2325
}

0 commit comments

Comments
 (0)