Add distro detection and enhanced error handling (#3)

Author: histrio

.github/workflows/test.yml

@@ -0,0 +1,35 @@
+name: Tests
+
+on:
+  push:
+    branches: [ master, main ]
+  pull_request:
+    branches: [ master, main ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+      fail-fast: false
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: Install uv
+      uses: astral-sh/setup-uv@v3
+      with:
+        enable-cache: true
+
+    - name: Set up project
+      run: uv sync --dev
+
+    - name: Run tests
+      run: uv run pytest test_kc_compat.py -v

.gitignore

@@ -0,0 +1 @@
+__pycache__

README.md

@@ -1,6 +1,6 @@
 # KernelChecker
 
-_kernelcheker.py_
+## kernelcheker.py
 KernelChecker was created to allow control panels to easily detect & advise
 users on updating running kernel. It can be used to promote KernelCare
 through the control panel. One of the goals behind creating this script was to to make it easier for control
@@ -67,25 +67,39 @@ else if needs_update == False {
 ```
 
 
-_kc-compat.py_
+## kc-compat.py
 Checks if server is running kernel compatible with KernelCare.
 Usage:
 ```bash
 python kc-compat.py [--silent|-q]
 ```
 
-Outputs COMPATIBLE if kernel supported, UNSUPPORTED and UNSUPPORTED; INSIDE CONTAINER
-if --silent flag is provided -- doesn't print anything
-Produces exit code 0 if compatible; 1 unsupported; 2 unsupported, inside container
+Outputs:
+- `COMPATIBLE` if kernel supported
+- `NEEDS REVIEW` manual validation is required
+- `UNSUPPORTED; INSIDE CONTAINER` if running inside a container
+- `CONNECTION ERROR; HTTP <code>` or `CONNECTION ERROR; <reason>` for network issues
+- `SYSTEM ERROR; <error>` for file system issues
+- `UNEXPECTED ERROR; <error>` for other errors
+
+If --silent flag is provided -- doesn't print anything
+
+Exit codes:
+- 0: compatible
+- 1: needs review
+- 2: unsupported, inside container
+- 3: connection error
+- 4: system error
+- 5: unexpected error
 
 Alternatively you can use: 
 ```bash
-curl -s https://raw.githubusercontent.com/iseletsk/kernelchecker/master/py/kc-compat.py|python
+curl -s https://raw.githubusercontent.com/cloudlinux/kcare-scripts/master/kc-compat.py | python
 ```
 
 or
 ```bash
-wget -qq -O - https://raw.githubusercontent.com/iseletsk/kernelchecker/master/py/kc-compat.py|python
+wget -qq -O - https://raw.githubusercontent.com/cloudlinux/kcare-scripts/master/kc-compat.py | python
 ```
 
 _Note: You cannot use exit code in this case, only output_

kc-compat.py

@@ -5,8 +5,9 @@
 
 try:
     from urllib.request import urlopen
+    from urllib.error import HTTPError, URLError
 except ImportError:
-    from urllib2 import urlopen
+    from urllib2 import urlopen, HTTPError, URLError
 
 __author__ = 'Igor Seletskiy'
 __copyright__ = "Copyright (c) Cloud Linux GmbH & Cloud Linux Software, Inc"
@@ -18,6 +19,21 @@
 __version__ = '1.0'
 
 
+SUPPORTED_DISTROS = {
+    "almalinux", 
+    "amzn",
+    "centos",
+    "cloudlinux",
+    "debian",
+    "ol",
+    "raspbian",
+    "rhel",
+    "rocky",
+    "ubuntu", 
+    "proxmox",
+}
+
+
 def get_kernel_hash():
     try:
         # noinspection PyCompatibility
@@ -43,13 +59,48 @@ def inside_lxc_container():
     return '/lxc/' in open('/proc/1/cgroup').read()
 
 
+def get_distro_info():
+    """
+    Get current distribution name and version
+    :return: distro name or None if detection fails
+    """
+    
+    def parse_value(line):
+        return line.split('=', 1)[1].strip().strip('"\'')
+    
+    os_release_path = '/etc/os-release'
+    if not os.path.exists(os_release_path):
+        return None
+
+    try:
+        with open(os_release_path, 'r') as f:
+            for line in f:
+                line = line.strip()
+                if line.startswith('ID='):
+                    return parse_value(line)
+    except (IOError, OSError):
+        return None
+
+
+def is_distro_supported(distro_name):
+    """
+    Check if the given distro name is supported
+    """
+    return distro_name in SUPPORTED_DISTROS
+
+
 def is_compat():
     url = 'http://patches.kernelcare.com/' + get_kernel_hash() + '/version'
     try:
         urlopen(url)
         return True
-    except Exception:
-        return False
+    except HTTPError as e:
+        if e.code == 404:
+            return False
+        else:
+            raise
+    except URLError:
+        raise
 
 
 def myprint(silent, message):
@@ -60,19 +111,41 @@ def myprint(silent, message):
 def main():
     """
     if --silent or -q argument provided, don't print anything, just use exit code
-    otherwise print results (COMPATIBLE or UNSUPPORTED)
+    otherwise print results (COMPATIBLE or support contact messages)
     else exit with 0 if COMPATIBLE, 1 or more otherwise
     """
     silent = len(sys.argv) > 1 and (sys.argv[1] == '--silent' or sys.argv[1] == '-q')
     if inside_vz_container() or inside_lxc_container():
         myprint(silent, "UNSUPPORTED; INSIDE CONTAINER")
         return 2
-    if is_compat():
-        myprint(silent, "COMPATIBLE")
-        return 0
-    else:
-        myprint(silent, "UNSUPPORTED")
-        return 1
+    
+    try:
+        if is_compat():
+            myprint(silent, "COMPATIBLE")
+            return 0
+        else:
+            # Handle 404 case - check if distro is supported
+            distro_name = get_distro_info()
+            if distro_name and is_distro_supported(distro_name):
+                myprint(silent, "NEEDS REVIEW")
+                myprint(silent, "We support your distribution, but we're having trouble detecting your precise kernel configuration. Please, contact CloudLinux Inc. support by email at [email protected] or by request form at https://www.cloudlinux.com/index.php/support")
+                return 1
+            else:
+                myprint(silent, "NEEDS REVIEW")
+                myprint(silent, "Please contact CloudLinux Inc. support by email at [email protected] or by request form at https://www.cloudlinux.com/index.php/support")
+                return 1
+    except HTTPError as e:
+        myprint(silent, "CONNECTION ERROR; HTTP %d" % e.code)
+        return 3
+    except URLError as e:
+        myprint(silent, "CONNECTION ERROR; %s" % str(e.reason))
+        return 3
+    except (IOError, OSError) as e:
+        myprint(silent, "SYSTEM ERROR; %s" % str(e))
+        return 4
+    except Exception as e:
+        myprint(silent, "UNEXPECTED ERROR; %s" % str(e))
+        return 5
 
 
 if __name__ == "__main__":

pyproject.toml

@@ -0,0 +1,30 @@
+[project]
+name = "kcare-scripts"
+version = "1.0"
+description = "KernelCare compatibility checking and kernel analysis scripts"
+readme = "README.md"
+requires-python = ">=3.9"
+dependencies = []
+authors = [
+    {name = "Igor Seletskiy", email = "[email protected]"}
+]
+maintainers = [
+    {name = "Igor Seletskiy", email = "[email protected]"},
+    {name = "Rinat Sabitov", email = "[email protected]"}
+]
+license = {text = "Apache-2.0"}
+keywords = ["kernel", "kernelcare", "compatibility", "linux", "security"]
+classifiers = [
+    "Development Status :: 5 - Production/Stable",
+    "Intended Audience :: System Administrators",
+    "License :: OSI Approved :: Apache Software License",
+    "Operating System :: POSIX :: Linux",
+    "Programming Language :: Python :: 3",
+    "Topic :: System :: Operating System Kernels :: Linux",
+    "Topic :: System :: Systems Administration",
+]
+
+[dependency-groups]
+dev = [
+    "pytest>=8.4.1",
+]