docker vs docker-command #3
Description
Currently, the only way to install cloudmesh-docker using cloudmesh-installer is by downloading the "source" bundle, which includes over 30 additional packages:
Screen Shot 2020-10-18 at 5 46 21 PM
There's also a "docker" bundle that doesn't contain cloudmesh-docker:
Screen Shot 2020-10-18 at 5 51 20 PM
This PR adds cloudmesh-docker to the "docker" bundle so that users can install cloudmesh-docker without installing 30+ additional packages.
@reillymarkowitz
add cloudmesh-docker repo to docker bundle
a5904e0
@laszewsk
laszewsk requested changes 1 hour ago
Member
laszewsk left a comment
This has to be done differently.
docker here means cmsd which is a dockerized container of cms
whet we do here is a different thing we start a docker command that uses docker from within cms not as the other package the uses docker from the outside.
We realize this can lead to confusion, but we had so far no docker command. so we need to start thinking about propper bundle names. As we use docker before it is unwise to make that change as it could impact the documentation of cmsd and lead to big confusions.
I have not yet thought about a proper bundle name for the docker command.
maybe "docker-command" would be ok
Member
laszewsk commented 1 hour ago
This is a good find, but not as easy to fix ...
Member
laszewsk commented 1 hour ago
I have added a bundle "docker-command" but did not yet provide any documentation for it. I think it deserves special attention and adds to the documentation in cloudmesh-docker and cloudmesh-cmsd
I think we need to add this even to the man pages.
Author
reillymarkowitz commented 20 minutes ago
Closing this PR because 2d2933e introduces a new "docker-command" bundle that solves the issue
@reillymarkowitz reillymarkowitz closed this 20 minutes ago
@laszewsk
Member
laszewsk commented 19 seconds ago
reopen the pull request as we need to make sure the documentation gets fixed and addresses teh existence of
docker
vs
docker-command