feat: fork to omit '--credentials' command for azure-blob-storage credentials

Signed-off-by: Tao Li <[email protected]>

Author: litaocdl

pkg/command/commandbuilder.go

@@ -115,6 +115,12 @@ func appendCloudProviderOptions(
 			break
 		}
 
+		// if flag to use DefaultAzureCredential, we do not
+		// append the --credentials command here
+		if forkCheckUseDefaultAzureCredentials(ctx) {
+			break
+		}
+
 		if !capabilities.HasAzureManagedIdentity {
 			err := fmt.Errorf(
 				"barman >= 2.18 is required to use azureInheritFromAzureAD, current: %v",
@@ -143,3 +149,19 @@ func appendCloudProviderOptions(
 
 	return options, nil
 }
+
+type contextKey string
+
+const useDefaultAzureCredentials contextKey = "useDefaultAzureCredentials"
+
+func forkCheckUseDefaultAzureCredentials(ctx context.Context) bool {
+	v := ctx.Value(useDefaultAzureCredentials)
+	if v == nil {
+		return false
+	}
+	result, ok := v.(bool)
+	if !ok {
+		return false
+	}
+	return result
+}

pkg/command/commandbuilder_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package command
 
 import (
+	"context"
 	"strings"
 
 	barmanApi "github.com/cloudnative-pg/barman-cloud/pkg/api"
@@ -57,3 +58,25 @@ var _ = Describe("barmanCloudWalRestoreOptions", func() {
 				))
 	})
 })
+
+var _ = Describe("forkCheckUseDefaultAzureCredentials", func() {
+	It("forkCheckUseDefaultAzureCredentials should be false by default", func(ctx SpecContext) {
+		Expect(forkCheckUseDefaultAzureCredentials(ctx)).To(BeFalse())
+	})
+
+	It("forkCheckUseDefaultAzureCredentials should be false if ctx contains invalid value", func(ctx SpecContext) {
+		newCtx := context.WithValue(ctx, useDefaultAzureCredentials, "invalidValue")
+		Expect(forkCheckUseDefaultAzureCredentials(newCtx)).To(BeFalse())
+	})
+
+	It("forkCheckUseDefaultAzureCredentials should be false if ctx contains false value", func(ctx SpecContext) {
+		newCtx := context.WithValue(ctx, useDefaultAzureCredentials, false)
+		Expect(forkCheckUseDefaultAzureCredentials(newCtx)).To(BeFalse())
+	})
+
+	It("forkCheckUseDefaultAzureCredentials should be true only if ctx contains true value", func(ctx SpecContext) {
+		newCtx := context.WithValue(ctx, useDefaultAzureCredentials, true)
+		Expect(forkCheckUseDefaultAzureCredentials(newCtx)).To(BeTrue())
+	})
+
+})