fix: misleading message about Azure if no ObjectStore credentials defined

lotheac · lotheac · commit 935903a43989 · 2026-02-03T20:17:52.000+09:00
if all of azureCredentials, googleCredentials and s3Credentials are nil,
the resulting error message says "missing Azure credentials", which is
misleading.

add a specific error message for this case.
diff --git a/pkg/credentials/env.go b/pkg/credentials/env.go
@@ -118,7 +118,11 @@ func envSetCloudCredentials(
 		return envSetGoogleCredentials(ctx, c, namespace, configuration.Google, env)
 	}
 
-	return envSetAzureCredentials(ctx, c, namespace, configuration, env)
+	if configuration.Azure != nil {
+		return envSetAzureCredentials(ctx, c, namespace, configuration, env)
+	}
+
+	return nil, fmt.Errorf("ObjectStoreConfiguration invalid: no credentials defined")
 }
 
 // envSetAWSCredentials sets the AWS environment variables given the configuration

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,11 @@ func envSetCloudCredentials(`
`118`	`118`	`return envSetGoogleCredentials(ctx, c, namespace, configuration.Google, env)`
`119`	`119`	`}`
`120`	`120`
`121`		`- return envSetAzureCredentials(ctx, c, namespace, configuration, env)`
	`121`	`+ if configuration.Azure != nil {`
	`122`	`+ return envSetAzureCredentials(ctx, c, namespace, configuration, env)`
	`123`	`+ }`
	`124`	`+`
	`125`	`+ return nil, fmt.Errorf("ObjectStoreConfiguration invalid: no credentials defined")`
`122`	`126`	`}`
`123`	`127`
`124`	`128`	`// envSetAWSCredentials sets the AWS environment variables given the configuration`