Proper conditional external cluster

Author: philippemnoel

.github/actions/deploy-cluster/action.yml

@@ -13,7 +13,7 @@ runs:
       env:
         NAMESPACE: ${{ inputs.namespace }}
       run: |
-        cat <<EOF | kubectl apply -f -
+        cat <<EOF | kubectl apply -f --server-side --validate=strict -f -
         # Example of PostgreSQL cluster
         apiVersion: postgresql.cnpg.io/v1
         kind: Cluster

.github/actions/deploy-operator/action.yml

@@ -21,7 +21,7 @@ runs:
         helm dependency update charts/cloudnative-pg
 
         helm upgrade
-        --install 
+        --install
         --namespace $NAMESPACE
         --create-namespace
         --set config.clusterWide=$CLUSTER_WIDE

charts/cluster/templates/_external_clusters.tpl

@@ -1,7 +1,14 @@
 {{- define "cluster.externalClusters" -}}
-externalClusters:
 {{- if eq .Values.mode "standalone" }}
-{{- else if eq .Values.mode "recovery" }}
+{{- if .Values.cluster.externalClusters }}
+externalClusters:
+{{- range .Values.cluster.externalClusters }}
+  - {{- toYaml . | nindent 4 }}
+{{- end }}
+{{- end }}
+{{- else }}
+externalClusters:
+{{- if eq .Values.mode "recovery" }}
   {{- if eq .Values.recovery.method "pg_basebackup" }}
   - name: pgBaseBackupSource
      {{- include "cluster.externalSourceCluster" .Values.recovery.pgBaseBackup.source | nindent 4 }}