Fixed default sql query for backend_waiting metric.
#684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed `backends_waiting` metric in default monitoring queries. Signed-off-by: Tianyuan Zhou <[email protected]>
zty200489
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed default sql query for
backend_waitingmetric, where multiple locks on the same row may cause spuriously high "blocked_queries".By adding
AND blocking_locks.granted, we only consider lock pairs where the blocking lock is granted (i.e. process is using the lock) and the blocked lock is not granted (i.e. is waiting for lock). This seems more appropriate since the dashboard displays this metric asBlocked Queries, whereas the original query collects all possible potential block pairs.