feat(monitoring): add support for additional labels in PodMonitor configuration #724
+64
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
racerand
reviewed
Nov 14, 2025
| {{- end }} | ||
| {{- if not (empty .Values.cluster.monitoring.podMonitor.labels) }} | ||
| {{- with .Values.cluster.monitoring.podMonitor.labels }} | ||
| podMonitorAdditionalLabels: |
There was a problem hiding this comment.
This key doesn't exist in the Cluster spec for monitoring. I believe the only way to solve this issue is to externalize the PodMonitor from the Cluster resource.
dosubot
bot
added
size:M
…figuration Signed-off-by: Nelson Alfonso <[email protected]>
…mplate Signed-off-by: Nelson Alfonso <[email protected]>
…figuration Signed-off-by: Nelson Alfonso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for adding custom labels to PodMonitor resources in the cluster Helm chart. This enhancement allows users to specify additional labels, which can be useful for integration with monitoring stacks or for team-based resource identification.
PodMonitor labels support:
labelsfield to thepodMonitorconfiguration incharts/cluster/values.yaml, enabling users to specify extra labels for PodMonitor resources.charts/cluster/templates/cluster.yamlto includepodMonitorAdditionalLabelswhen custom labels are provided, ensuring these labels are applied to the generated PodMonitor resource.charts/cluster/values.schema.jsonto define the newlabelsfield as an object, validating user input for this configuration option.closes: #647