allow certificate isssuer to be optional, wire issuerName#811
Open
North14 wants to merge 1 commit intocloudnative-pg:mainfrom
Open
allow certificate isssuer to be optional, wire issuerName#811North14 wants to merge 1 commit intocloudnative-pg:mainfrom
North14 wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
North14
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
the
size:S
North14
force-pushed
the
north/fix-issuer-optional
branch
2 times, most recently
from
5876024 to
864723a
Compare
Signed-off-by: FA <filip@artifact.se>
North14
force-pushed
the
north/fix-issuer-optional
branch
from
864723a to
998e402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes to the chart for plugin-barman-cloud:
Allows creation of issuer to be optional by adding (.Values.certificate.createIssuer) a boolean switch (and therefore removes cert-manager as a dependency)
.Values.certificate.issuerName is previously unusued. This change wires it to the name of certificate issuer
Closes #810