feat: forbid usage of .spec.configuration.serverName in ObjectStore (#336)

Closes #334

Signed-off-by: Marco Nenciarini <[email protected]>

Author: mnencia

api/v1/objectstore_types.go

@@ -38,6 +38,7 @@ type InstanceSidecarConfiguration struct {
 // ObjectStoreSpec defines the desired state of ObjectStore.
 type ObjectStoreSpec struct {
 	// The configuration for the barman-cloud tool suite
+	// +kubebuilder:validation:XValidation:rule="!has(self.serverName)",fieldPath=".serverName",reason="FieldValueForbidden",message="use the 'serverName' plugin parameter in the Cluster resource"
 	Configuration barmanapi.BarmanObjectStoreConfiguration `json:"configuration"`
 
 	// RetentionPolicy is the retention policy to be used for backups

config/crd/bases/barmancloud.cnpg.io_objectstores.yaml

@@ -382,6 +382,11 @@ spec:
                 required:
                 - destinationPath
                 type: object
+                x-kubernetes-validations:
+                - fieldPath: .serverName
+                  message: use the 'serverName' plugin parameter in the Cluster resource
+                  reason: FieldValueForbidden
+                  rule: '!has(self.serverName)'
               instanceSidecarConfiguration:
                 description: The configuration for the sidecar that runs in the instance
                   pods

manifest.yaml

@@ -381,6 +381,11 @@ spec:
                 required:
                 - destinationPath
                 type: object
+                x-kubernetes-validations:
+                - fieldPath: .serverName
+                  message: use the 'serverName' plugin parameter in the Cluster resource
+                  reason: FieldValueForbidden
+                  rule: '!has(self.serverName)'
               instanceSidecarConfiguration:
                 description: The configuration for the sidecar that runs in the instance
                   pods