test(e2e): replica cluster (#88)

Signed-off-by: Francesco Canovai <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Co-authored-by: Leonardo Cecchi <[email protected]>

Author: fcanovai

Taskfile.yml

@@ -204,7 +204,7 @@ tasks:
     deps:
       - build-images
     cmds:
-      - go test -timeout 30m -v ./test/e2e
+      - go test -timeout 60m -v ./test/e2e
 
   ci:
     desc: Run the CI pipeline

test/e2e/e2e_suite_test.go

@@ -41,6 +41,7 @@ import (
 	"github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/kustomize"
 
 	_ "github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/tests/backup"
+	_ "github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/tests/replicacluster"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"

test/e2e/internal/objectstore/azurite.go

@@ -31,8 +31,9 @@ import (
 	pluginBarmanCloudV1 "github.com/cloudnative-pg/plugin-barman-cloud/api/v1"
 )
 
-func NewAzuriteObjectStoreResources(namespace, name string) Resources {
-	return Resources{
+// NewAzuriteObjectStoreResources creates the resources required to create an Azurite object store.
+func NewAzuriteObjectStoreResources(namespace, name string) *Resources {
+	return &Resources{
 		Deployment: newAzuriteDeployment(namespace, name),
 		Service:    newAzuriteService(namespace, name),
 		PVC:        newAzuritePVC(namespace, name),
@@ -174,6 +175,7 @@ func newAzuritePVC(namespace, name string) *corev1.PersistentVolumeClaim {
 	}
 }
 
+// NewAzuriteObjectStore creates a new ObjectStore object for Azurite.
 func NewAzuriteObjectStore(namespace, name, azuriteOSName string) *pluginBarmanCloudV1.ObjectStore {
 	return &pluginBarmanCloudV1.ObjectStore{
 		TypeMeta: metav1.TypeMeta{

test/e2e/internal/objectstore/fakegcsserver.go

@@ -31,8 +31,9 @@ import (
 	pluginBarmanCloudV1 "github.com/cloudnative-pg/plugin-barman-cloud/api/v1"
 )
 
-func NewGCSObjectStoreResources(namespace, name string) Resources {
-	return Resources{
+// NewGCSObjectStoreResources creates the resources required to create a GCS object store.
+func NewGCSObjectStoreResources(namespace, name string) *Resources {
+	return &Resources{
 		Deployment: newGCSDeployment(namespace, name),
 		Service:    newGCSService(namespace, name),
 		Secret:     newGCSSecret(namespace, name),
@@ -76,7 +77,8 @@ func newGCSDeployment(namespace, name string) *appsv1.Deployment {
 								},
 							},
 							Command: []string{"fake-gcs-server"},
-							Args: []string{"-scheme",
+							Args: []string{
+								"-scheme",
 								"http",
 								"-port",
 								"4443",
@@ -167,6 +169,7 @@ func newGCSPVC(namespace, name string) *corev1.PersistentVolumeClaim {
 	}
 }
 
+// NewGCSObjectStore creates a new GCS object store.
 func NewGCSObjectStore(namespace, name, gcsOSName string) *pluginBarmanCloudV1.ObjectStore {
 	return &pluginBarmanCloudV1.ObjectStore{
 		TypeMeta: metav1.TypeMeta{

test/e2e/internal/objectstore/minio.go

@@ -31,8 +31,9 @@ import (
 	pluginBarmanCloudV1 "github.com/cloudnative-pg/plugin-barman-cloud/api/v1"
 )
 
-func NewMinioObjectStoreResources(namespace, name string) Resources {
-	return Resources{
+// NewMinioObjectStoreResources creates the resources required to create a Minio object store.
+func NewMinioObjectStoreResources(namespace, name string) *Resources {
+	return &Resources{
 		Deployment: newMinioDeployment(namespace, name),
 		Service:    newMinioService(namespace, name),
 		PVC:        newMinioPVC(namespace, name),
@@ -189,6 +190,7 @@ func newMinioPVC(namespace, name string) *corev1.PersistentVolumeClaim {
 	}
 }
 
+// NewMinioObjectStore creates a new Minio object store.
 func NewMinioObjectStore(namespace, name, minioOSName string) *pluginBarmanCloudV1.ObjectStore {
 	return &pluginBarmanCloudV1.ObjectStore{
 		TypeMeta: metav1.TypeMeta{

test/e2e/internal/objectstore/objectstore.go

@@ -20,37 +20,45 @@ import (
 	"context"
 	"fmt"
 
-	"k8s.io/api/apps/v1"
-	v2 "k8s.io/api/core/v1"
+	appsv1 "k8s.io/api/apps/v1"
+	corev1 "k8s.io/api/core/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 const (
-	// Size of the PVCs for the object stores
+	// DefaultSize is the default size of the PVCs for the object stores.
 	DefaultSize = "1Gi"
 )
 
 // Resources represents the resources required to create an object store.
 type Resources struct {
-	Deployment *v1.Deployment
-	Service    *v2.Service
-	Secret     *v2.Secret
-	PVC        *v2.PersistentVolumeClaim
+	Deployment *appsv1.Deployment
+	Service    *corev1.Service
+	Secret     *corev1.Secret
+	PVC        *corev1.PersistentVolumeClaim
 }
 
 // Create creates the object store resources.
 func (osr Resources) Create(ctx context.Context, cl client.Client) error {
-	if err := cl.Create(ctx, osr.PVC); err != nil {
-		return fmt.Errorf("failed to create PVC: %w", err)
+	if osr.PVC != nil {
+		if err := cl.Create(ctx, osr.PVC); err != nil {
+			return fmt.Errorf("failed to create PVC: %w", err)
+		}
 	}
-	if err := cl.Create(ctx, osr.Secret); err != nil {
-		return fmt.Errorf("failed to create secret: %w", err)
+	if osr.Secret != nil {
+		if err := cl.Create(ctx, osr.Secret); err != nil {
+			return fmt.Errorf("failed to create secret: %w", err)
+		}
 	}
-	if err := cl.Create(ctx, osr.Deployment); err != nil {
-		return fmt.Errorf("failed to create deployment: %w", err)
+	if osr.Deployment != nil {
+		if err := cl.Create(ctx, osr.Deployment); err != nil {
+			return fmt.Errorf("failed to create deployment: %w", err)
+		}
 	}
-	if err := cl.Create(ctx, osr.Service); err != nil {
-		return fmt.Errorf("failed to create service: %w", err)
+	if osr.Service != nil {
+		if err := cl.Create(ctx, osr.Service); err != nil {
+			return fmt.Errorf("failed to create service: %w", err)
+		}
 	}
 
 	return nil

test/e2e/internal/tests/backup/fixtures.go

@@ -34,7 +34,7 @@ const (
 	minio   = "minio"
 	azurite = "azurite"
 	gcs     = "gcs"
-	// Size of the PVCs for the object stores and the cluster instances
+	// Size of the PVCs for the object stores and the cluster instances.
 	size               = "1Gi"
 	srcClusterName     = "source"
 	srcBackupName      = "source"
@@ -48,7 +48,7 @@ type testCaseFactory interface {
 }
 
 type backupRestoreTestResources struct {
-	ObjectStoreResources objectstore.Resources
+	ObjectStoreResources *objectstore.Resources
 	ObjectStore          *pluginBarmanCloudV1.ObjectStore
 	SrcCluster           *cloudnativepgv1.Cluster
 	SrcBackup            *cloudnativepgv1.Backup

test/e2e/internal/tests/replicacluster/doc.go

@@ -0,0 +1,19 @@
+/*
+Copyright 2024.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// Package replicacluster contains tests validating replica clusters
+// using the Barman Cloud Plugin.
+package replicacluster