Skip to content

Commit 89cdc2a

Browse files
author
Murali Reddy
committed
Incorrect generation of unique service key when building service and endpoint maps
use spec.ports.name in the service manifest to uniqely generate service key used internally to lookup services info and endpoints info maps closes #3
1 parent c0a6000 commit 89cdc2a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/controllers/network_services_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ func buildServicesInfo() serviceInfoMap {
316316
nodePort: int(port.NodePort),
317317
}
318318
svcInfo.sessionAffinity = (svc.Spec.SessionAffinity == "ClientIP")
319-
svcId := generateServiceId(svc.Namespace, svc.Name, strconv.Itoa(int(port.Port)))
319+
svcId := generateServiceId(svc.Namespace, svc.Name, port.Name)
320320
serviceMap[svcId] = &svcInfo
321321
}
322322
}
@@ -328,7 +328,7 @@ func buildEndpointsInfo() endpointsInfoMap {
328328
for _, ep := range watchers.EndpointsWatcher.List() {
329329
for _, ep_subset := range ep.Subsets {
330330
for _, port := range ep_subset.Ports {
331-
svcId := generateServiceId(ep.Namespace, ep.Name, strconv.Itoa(int(port.Port)))
331+
svcId := generateServiceId(ep.Namespace, ep.Name, port.Name)
332332
endpoints := make([]endpointsInfo, 0)
333333
for _, addr := range ep_subset.Addresses {
334334
endpoints = append(endpoints, endpointsInfo{ip: addr.IP, port: int(port.Port)})

0 commit comments

Comments
 (0)